Review main Merged

83923[BUGFIX] Add missing "true" parameter in loadAvailableWizardsFromPluginSubTypes

Nikita Hovratov CR +2 V +2 Normal +195 −1 updated 04/19/24, 09:31

Commit message

New Content Element Wizards are retrieved from both normal Content Types
(CType) and Plugin sub-types (list_type). For the latter the bool
parameter `$isPluginSubType` has to be set to `true`.

Tests are added to ensure correct functionality.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1214

  1. Nikita Hovratov uploaded patch set 1 04/18/24, 16:15

  2. core-ci voted on patch set 1 V +1 04/18/24, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56269

  3. Georg Ringer voted on patch set 1 CR +1 V +1 04/18/24, 16:51

  4. Oliver Klee commented on patch set 1 04/18/24, 17:34

    NewContentElementWizardControllerTest.php:26

    Can we skip using the database for this testcase in order to improve test performance?
  5. Nikita Hovratov uploaded patch set 2 CR +1 V +1 04/18/24, 18:08

  6. Nikita Hovratov commented on patch set 2 04/18/24, 18:09

    NewContentElementWizardControllerTest.php:26 Reply

    Thanks for the hint!
  7. core-ci voted on patch set 2 V +1 04/18/24, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56272

  8. Oliver Klee voted on patch set 2 V +1 04/18/24, 18:24

  9. Garvin Hicking voted on patch set 2 CR +1 V +1 04/18/24, 21:20

  10. Benni Mack voted on patch set 2 CR +1 V +1 04/18/24, 21:22

  11. Nikita Hovratov voted on patch set 2 CR +2 V +2 04/19/24, 07:22

  12. Nikita Hovratov merged patch set 3 04/19/24, 07:23

  13. Christian Kuhn commented on patch set 3 04/19/24, 09:14

    NewContentElementWizardControllerTest.php:180

  14. Nikita Hovratov commented on patch set 3 04/19/24, 09:31

    NewContentElementWizardControllerTest.php:180 Reply

    Done