Review main Merged

83924[TASK] Revamp display of "Workspaces" backend module

Jasmina Ließmann CR +2 V +2 Hard +171 −201 updated 04/23/24, 14:14

Commit message

To improve the UX and accessibility of the "Workspaces" backend module
the following changes are made:
* Grouping and rearranging action buttons
* Showing system language title in addition to the flag icon
* Addition of a new "Action" column to represent the type of change and
  resolve the previous workspace state legend and colored record titles
* Output notification messages with the icon if integrity issues exists
* Removal of the live record column (This only contained the name of
  the live record and no other function. Additionally, records created
  in workspace were also displayed incorrectly in the live column even
  though they did not yet exist in live environment.)

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1727

Show 12 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 04/18/24, 23:01

  2. core-ci voted on patch set 1 V +1 04/18/24, 23:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56276

  1. Jasmina Ließmann uploaded patch set 2 V +1 04/19/24, 10:40

  2. core-ci voted on patch set 2 V +1 04/19/24, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56328

  3. Jasmina Ließmann uploaded patch set 3 V +1 04/19/24, 11:03

  4. core-ci voted on patch set 3 V +1 04/19/24, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56329

  5. Jasmina Ließmann updated the commit message in patch set 4 V +1 04/19/24, 11:13

  6. core-ci voted on patch set 4 V +1 04/19/24, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56331

  7. Jasmina Ließmann uploaded patch set 5 V +1 04/19/24, 12:31

  8. core-ci voted on patch set 5 V +1 04/19/24, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56334

  9. Jasmina Ließmann uploaded patch set 6 V +1 04/19/24, 13:21

  10. core-ci voted on patch set 6 V -1 04/19/24, 13:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56342

  11. Jasmina Ließmann uploaded patch set 7 V -1 04/22/24, 23:03

  12. core-ci voted on patch set 7 V +1 04/22/24, 23:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56512

  13. Jasmina Ließmann uploaded patch set 8 V +1 04/22/24, 23:11

  14. core-ci voted on patch set 8 V +1 04/22/24, 23:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56513

  15. Jasmina Ließmann updated the commit message in patch set 9 V +1 04/22/24, 23:26

  16. core-ci voted on patch set 9 V +1 04/22/24, 23:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56516

  17. Jasmina Ließmann uploaded patch set 10 V +1 04/22/24, 23:48

  18. core-ci voted on patch set 10 V +1 04/22/24, 23:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56519

  19. Christian Kuhn voted on patch set 10 CR +1 V +1 04/22/24, 23:56

  20. Stefan Bürk voted on patch set 10 CR +1 V +1 04/23/24, 00:12

  21. Riccardo De Contardi commented on patch set 10 04/23/24, 07:21

    I wonder if the column "Action" could be renamed "Status" instead. "Action" makes me think that there is some "action" there I should perform for each record

    locallang.xlf:143

    What about "Status" instead of "Action" ?
  22. Jasmina Ließmann commented on patch set 10 04/23/24, 07:40

    locallang.xlf:143 Reply

    This column shows what type of change was made to the record. “Status” doesn’t do it justice in my opinion. There is also a “Stage” column, which to me is more like a status. In the History/Undo view there is also an “Action” column which contains such action types/labels. I would leave it at this label. Is this OK for you?
  23. Christian Kuhn commented on patch set 10 04/23/24, 13:01

    locallang.xlf:143 Reply

    Done
  24. Jasmina Ließmann voted on patch set 10 CR +2 V +2 04/23/24, 14:13

  25. Jasmina Ließmann merged patch set 11 04/23/24, 14:14