83924[TASK] Revamp display of "Workspaces" backend module
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 13
- Build/Sources/Sass/component/_table.scss+6 −1
- Build/Sources/Sass/module/_workspaces.scss+0 −44
- Build/Sources/TypeScript/workspaces/renderable/record-table.ts+93 −55
- Build/Sources/TypeScript/workspaces/backend.ts+2 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+3 −11
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+0 −2
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+0 −1
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+2 −6
- typo3/sysext/workspaces/Resources/Private/Language/locallang.xlf3+24 −27
- typo3/sysext/workspaces/Resources/Private/Partials/Legend.htmldeleted+0 −14
- typo3/sysext/workspaces/Resources/Private/Templates/Review/Index.html+0 −2
- typo3/sysext/workspaces/Resources/Public/JavaScript/renderable/record-table.js+40 −35
- typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js+1 −1
Review log 1727
Show 12 earlier messages
-
Jasmina Ließmann uploaded patch set 1 04/18/24, 23:01
-
core-ci voted on patch set 1 V +1 04/18/24, 23:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56276
-
Jasmina Ließmann uploaded patch set 2
V +104/19/24, 10:40 -
core-ci voted on patch set 2 V +1 04/19/24, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56328
-
Jasmina Ließmann uploaded patch set 3
V +104/19/24, 11:03 -
core-ci voted on patch set 3 V +1 04/19/24, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56329
-
Jasmina Ließmann updated the commit message in patch set 4
V +104/19/24, 11:13 -
core-ci voted on patch set 4 V +1 04/19/24, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56331
-
Jasmina Ließmann uploaded patch set 5
V +104/19/24, 12:31 -
core-ci voted on patch set 5 V +1 04/19/24, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56334
-
Jasmina Ließmann uploaded patch set 6
V +104/19/24, 13:21 -
core-ci voted on patch set 6 V -1 04/19/24, 13:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56342
-
Jasmina Ließmann uploaded patch set 7
V -104/22/24, 23:03 -
core-ci voted on patch set 7 V +1 04/22/24, 23:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56512
-
Jasmina Ließmann uploaded patch set 8
V +104/22/24, 23:11 -
core-ci voted on patch set 8 V +1 04/22/24, 23:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56513
-
Jasmina Ließmann updated the commit message in patch set 9
V +104/22/24, 23:26 -
core-ci voted on patch set 9 V +1 04/22/24, 23:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56516
-
Jasmina Ließmann uploaded patch set 10
V +104/22/24, 23:48 -
core-ci voted on patch set 10 V +1 04/22/24, 23:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56519
-
Christian Kuhn voted on patch set 10 CR +1 V +1 04/22/24, 23:56
-
Stefan Bürk voted on patch set 10 CR +1 V +1 04/23/24, 00:12
-
Riccardo De Contardi commented on patch set 10 04/23/24, 07:21
I wonder if the column "Action" could be renamed "Status" instead. "Action" makes me think that there is some "action" there I should perform for each recordlocallang.xlf:143What about "Status" instead of "Action" ? -
Jasmina Ließmann commented on patch set 10 04/23/24, 07:40
locallang.xlf:143ReplyThis column shows what type of change was made to the record. “Status” doesn’t do it justice in my opinion. There is also a “Stage” column, which to me is more like a status. In the History/Undo view there is also an “Action” column which contains such action types/labels. I would leave it at this label. Is this OK for you? -
Christian Kuhn commented on patch set 10 04/23/24, 13:01
locallang.xlf:143ReplyDone -
Jasmina Ließmann voted on patch set 10 CR +2 V +2 04/23/24, 14:13
-
Jasmina Ließmann merged patch set 11 04/23/24, 14:14