Review main Merged

83927[BUGFIX] Attach nonce attribute to script tag in admin panel's submodule

Chris Müller CR +2 V +2 Easy +1 −1 updated 04/21/24, 19:17

Commit message

When providing a custom submodule for the admin panel with JavaScript,
the script tag does not have a nonce attribute attached. The $attributes
argument of the getAdditionalResourcesForModules() method holds a
"useNonce" configuration, which is now also passed to
getAdditionalResourcesForModules(), like for other calls in this
method.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Chris Müller uploaded patch set 1 04/19/24, 08:10

  2. core-ci voted on patch set 1 V +1 04/19/24, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56310

  3. Georg Ringer voted on patch set 1 CR +1 V +1 04/19/24, 08:17

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 04/21/24, 19:10

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 04/21/24, 19:11

  6. Stefan Bürk merged patch set 2 04/21/24, 19:17