Review main Merged

83929[TASK] Simplify a RelationHandler->readMM() detail

Christian Kuhn CR +2 V +2 Easy +12 −15 updated 04/19/24, 09:45

Commit message

There is a relatively obscure and not well known TCA
config property for type='select': 'allowNonIdValues'.

It can be used in scenarios with 'foreign_table'
relations, where select stores the uids of selected
records as CSV list: It allows additional items
next to "true" relations, for instance items from a
static 'items' list. To keep "true" relations and
"additional static values" apart, those static values
must be some string that can not be interpreted as an
integer uid.

This only works when select stores selections
as CSV list: When using an MM table, relation uids
are forced to be integers. This is documented, too.

RelationHandler still handles 'allowNonIdValues' in
its MM related readMM() method, which is obsolete
code since that can not work.

The patch clean this up and simplifies readMM() a
bit along the way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 04/19/24, 08:40

  2. core-ci voted on patch set 1 V +1 04/19/24, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56312

  3. Nikita Hovratov voted on patch set 1 CR +1 V +1 04/19/24, 09:31

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 04/19/24, 09:42

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 04/19/24, 09:45

  6. Christian Kuhn merged patch set 2 04/19/24, 09:45