83934[BUGFIX] Ensure table definition overrides work again
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Nikita Hovratov +1
- Jörg Bösche +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 3
Files 2
Review log 811
-
Stefan Bürk uploaded patch set 1 04/19/24, 09:30
-
core-ci voted on patch set 1 V +1 04/19/24, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56322
-
core-ci commented on patch set 1 04/19/24, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56324
-
Nikita Hovratov uploaded patch set 2
V +104/19/24, 10:04 -
Nikita Hovratov commented on patch set 2 CR +1 V +1 04/19/24, 10:05
Changed Closure::bind to ReflectionMethod. Hope it's fine. -
core-ci voted on patch set 2 V +1 04/19/24, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56325
-
Stefan Bürk commented on patch set 2 04/19/24, 10:21
Reply
Why ? No need for a reflection here. In the end, it works. -
Christian Kuhn commented on patch set 2 CR +1 V +1 04/19/24, 12:14
Reply
calling the private method via reflection is imho more clean that the closure. -
Jörg Bösche voted on patch set 2 CR +1 04/19/24, 12:19
-
Stefan Bürk voted on patch set 2 CR +2 V +2 04/19/24, 12:26
-
Stefan Bürk merged patch set 3 04/19/24, 12:26