Review main Merged

83935[DOCS] Revise changelogs for v13.1 release

Chris Müller CR +2 V +2 Hard +158 −148 updated 04/23/24, 04:41

Commit message

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 1619

  1. Chris Müller uploaded patch set 1 04/19/24, 10:08

  2. Chris Müller marked it work in progress 04/19/24, 10:08

  3. core-ci voted on patch set 1 V +1 04/19/24, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56327

  4. Chris Müller uploaded patch set 2 V +1 04/21/24, 13:56

  5. Chris Müller marked it ready for review 04/21/24, 13:56

  6. core-ci voted on patch set 2 V +1 04/21/24, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56427

  7. Garvin Hicking commented on patch set 2 04/21/24, 19:07

    Thanks for combing through this and making a unified version!

    Feature-103439-TypoScriptProviderForSitesAndSets.rst:15

    maybe :sql:'sys_template' even?

    Feature-103439-TypoScriptProviderForSitesAndSets.rst:17

    same

    Feature-103504-NewContentObjectPageView.rst:36

    Maybe instead lowercasing layouts/partials, use :file: and keep uppercase, as it refers to those dirs?
  8. Chris Müller commented on patch set 2 04/22/24, 04:57

    Feature-103504-NewContentObjectPageView.rst:36 Reply

    No need, as the paths are mentioned at the end of the sentence.
  9. Garvin Hicking commented on patch set 2 04/22/24, 05:08

    Feature-103504-NewContentObjectPageView.rst:36 Reply

    But as for now the Uppercase way is the more common/preferred one. Also :file: would make sense here IMO. But not the hill I die on, so ok :-D
  10. Chris Müller uploaded patch set 3 V +1 04/22/24, 16:11

  11. Chris Müller commented on patch set 3 04/22/24, 16:11

    Feature-103439-TypoScriptProviderForSitesAndSets.rst:15 Reply

    Done

    Feature-103439-TypoScriptProviderForSitesAndSets.rst:17 Reply

    Done
  12. core-ci voted on patch set 3 V +1 04/22/24, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56500

  13. Garvin Hicking commented on patch set 3 04/22/24, 17:11

    Feature-103504-NewContentObjectPageView.rst:50

    I wonder if this block may raise more questions? The changelog file is all about TypoScript and Fluid. Crossing over to the PHP boundary for extra objects would raise the question, how and where you would actually perform this? Maybe move this to the "migration" section and i.e. connect it to custom data processors?

    Feature-103504-NewContentObjectPageView.rst:168

    Either "trying to do so" or "trying to"?
  14. Garvin Hicking commented on patch set 3 CR +1 V +1 04/22/24, 17:46

    (advancd +1 if this needs to go in quickly for the release)
  15. Georg Ringer voted on patch set 3 CR +1 V +1 04/22/24, 18:52

  16. Anja Leichsenring voted on patch set 3 CR +1 V +1 04/23/24, 04:37

  17. Anja Leichsenring voted on patch set 3 CR +2 V +2 04/23/24, 04:38

  18. Anja Leichsenring commented on patch set 3 04/23/24, 04:41

    Feature-103504-NewContentObjectPageView.rst:50 Reply

    good enough I'd say. Should be taken up in documentation nonetheless.

    Feature-103504-NewContentObjectPageView.rst:168 Reply

    Acknowledged
  19. Anja Leichsenring merged patch set 4 04/23/24, 04:41