Review main Merged

83936[TASK] Rename `@typo3/backend/new-content-element-wizard` component

Andreas Kienast CR +2 V +2 Normal +40 −30 updated 04/22/24, 07:45

Commit message

The component `@typo3/backend/new-content-element-wizard` is primarily
used to render a wizard-like UI for selecting a content element for
creation.
To make the component usable in other places as well, it get's renamed
to `@typo3/backend/new-record-wizard`.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 912

  1. Andreas Kienast uploaded patch set 1 04/19/24, 12:11

  2. core-ci voted on patch set 1 V -1 04/19/24, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56332

  3. Andreas Kienast uploaded patch set 2 V -1 04/19/24, 12:38

  4. core-ci voted on patch set 2 V +1 04/19/24, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56335

  5. Oli Bartsch commented on patch set 2 04/19/24, 15:54

    new-record-wizard.ts:337

    Since we make this module generic, we should also use generic labels for the defaults.
  6. Andreas Kienast commented on patch set 2 04/21/24, 11:56

    new-record-wizard.ts:337 Reply

    Acknowledged
  7. Andreas Kienast uploaded patch set 3 V +1 04/21/24, 12:02

  8. core-ci voted on patch set 3 V +1 04/21/24, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56424

  9. Georg Ringer voted on patch set 3 CR +1 V +1 04/21/24, 18:40

  10. Oli Bartsch voted on patch set 3 CR +1 V +1 04/21/24, 19:06

  11. Andreas Kienast voted on patch set 3 CR +2 V +2 04/22/24, 07:45

  12. Andreas Kienast merged patch set 4 04/22/24, 07:45