Review main Merged

83937[TASK] Use "new record wizard" to render dashboard widgets

Andreas Kienast CR +2 V +2 Normal +60 −73 updated 04/22/24, 18:51

Commit message

In order to streamline the backend UI and to re-use introduced web
components, the "Add widget" wizard in the dashboard module now utilizes
the `@typo3/backend/new-record-wizard` module that is already known from
the Content Element creation wizard.

As a small quality-of-life change, the modal title now includes the name
of the dashboard as well.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1522

  1. Andreas Kienast uploaded patch set 1 04/19/24, 12:13

  2. core-ci voted on patch set 1 V -1 04/19/24, 12:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56333

  3. Andreas Kienast uploaded patch set 2 V -1 04/22/24, 08:23

  4. core-ci voted on patch set 2 V -1 04/22/24, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56475

  5. Andreas Kienast uploaded patch set 3 V -1 04/22/24, 09:22

  6. core-ci voted on patch set 3 V -1 04/22/24, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56480

  7. Andreas Kienast uploaded patch set 4 V -1 04/22/24, 10:33

  8. core-ci voted on patch set 4 V -1 04/22/24, 10:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56482

  9. Andreas Kienast uploaded patch set 5 V -1 04/22/24, 10:40

  10. Benjamin Franzke voted on patch set 5 CR +1 V +1 04/22/24, 10:42

  11. Andreas Kienast uploaded patch set 6 CR +1 V +1 04/22/24, 10:44

  12. core-ci voted on patch set 5 V +1 04/22/24, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56484

  13. core-ci voted on patch set 6 V +1 04/22/24, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56485

  14. Simon Schaufelberger voted on patch set 6 CR +1 04/22/24, 13:06

  15. Oli Bartsch voted on patch set 6 CR +1 V +1 04/22/24, 13:28

  16. Nikita Hovratov commented on patch set 6 04/22/24, 18:26

    WidgetGroupInitializationService.php:65

    Maybe better add a continue statement above when $widgets is empty? This oneliner doesn't really contribute to code readability.
  17. Andreas Kienast commented on patch set 6 04/22/24, 18:32

    WidgetGroupInitializationService.php:65 Reply

    Fine for me.
  18. Andreas Kienast uploaded patch set 7 CR +1 V +1 04/22/24, 18:32

  19. core-ci voted on patch set 7 V +1 04/22/24, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56507

  20. Nikita Hovratov voted on patch set 7 CR +1 V +1 04/22/24, 18:40

  21. Georg Ringer voted on patch set 7 CR +2 V +2 04/22/24, 18:51

  22. Georg Ringer merged patch set 8 04/22/24, 18:51