83942[TASK] Unify Rollup usage in frontend tooling
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 17
- Build/rollup/ckeditor/build-translations-config.jsrenamed+0 −0
- Build/rollup/shim/style-inject.jsrenamed+0 −0
- Build/rollup/bootstrap.jsnew+21 −0
- Build/rollup/chartjs.jsnew+24 −0
- Build/rollup/ckeditor.jsrenamed+6 −6
- Build/rollup/lodash.jsnew+22 −0
- Build/rollup/select-pure.jsnew+31 −0
- Build/Gruntfile.js+2 −123
- Build/package-lock.json+32 −46
- Build/package.json+1 −2
- Build/rollup.config.js2new+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/lodash-es.js+3 −2
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/select-pure.js+12 −12
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js+2 −2
- typo3/sysext/dashboard/Resources/Public/JavaScript/Contrib/chartjs.js+3 −3
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-ui.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-utils.js+1 −1
Review log 1521
-
Andreas Nedbal uploaded patch set 1 04/19/24, 19:00
-
core-ci voted on patch set 1 V -1 04/19/24, 19:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56352
-
Andreas Nedbal uploaded patch set 2
V -104/19/24, 19:13 -
core-ci voted on patch set 2 V +1 04/19/24, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56353
-
Andreas Nedbal uploaded patch set 3
V +104/19/24, 19:40 -
core-ci voted on patch set 3 V +1 04/19/24, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56355
-
Benjamin Franzke commented on patch set 3 04/23/24, 10:31
Nice in general 👍v12 possiblelibraries.js:3If we start splitting anyway, maybe one file per lib? -
Benjamin Franzke commented on patch set 3 04/23/24, 10:38
rollup.config.js:1We should not write internal libs to the `Scripts` folder. Let's instead just place the rollup code in `Build/rollup/`. -
Benjamin Franzke commented on patch set 3 CR -1 04/23/24, 10:49
on it -
Benjamin Franzke uploaded patch set 4
CR -1V +104/23/24, 11:29 -
Benjamin Franzke commented on patch set 4 04/23/24, 11:29
Reply
Doneckeditor.js:26old ckeditor config not (re)movedlibraries.js:3ReplyDonerollup.config.js:1ReplyDone -
Benjamin Franzke uploaded patch set 5 04/23/24, 11:32
-
Benjamin Franzke uploaded patch set 6 04/23/24, 11:35
-
Benjamin Franzke commented on patch set 6 CR +1 V +1 04/23/24, 11:36
libraries.js:61IMO this mapping was not useful (we introduce an own/new rollup-subset in the config above). Therefore I've refactored this pack to plain rollup config. -
core-ci voted on patch set 4 V -1 04/23/24, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56570
-
core-ci voted on patch set 5 V -1 04/23/24, 11:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56571
-
core-ci voted on patch set 6 V +1 04/23/24, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56572
-
Benni Mack commented on patch set 6 CR +1 V +1 04/23/24, 13:20
love that one! -
Andreas Kienast voted on patch set 6 CR +1 V +1 04/23/24, 14:09
-
Benjamin Franzke voted on patch set 6 CR +2 V +2 04/23/24, 14:32
-
Benjamin Franzke merged patch set 7 04/23/24, 14:32