Review main Merged

83943[FEATURE] Add `UNION Clause` support to the QueryBuilder

Stefan Bürk CR +2 V +2 Hard +658 −0 updated 08/16/24, 13:07

Commit message

The `UNION Clause` is used to combine the result-set of
two or more `SELECT` SQL queries suported by all database
vendors - at least on a shared basic level with the usual
special vendor enhancements.

There is a common shared subset working for all of them:

    SELECT column_name(s) FROM table1
    WHERE ...

    UNION <ALL | DISTINCT>

    SELECT column_name(s) FROM table2
    WHERE ...

    ORDER BY ...
    LIMIT x OFFSET y

Instead of introducing the `UNION Clause` support into
the TYPO3 QueryBuilder, the challenge was taken to add
this directly into Doctrine DBAL [1]. The effort was
rewarded and with the release of `Doctrine DBAL 4.1.0`
`UNION Clause` [2] the support is included.

This change adopts the new feature into the extended
`ConcreteQueryBuilder` and `QueryBuilder` to support
extension authors with a simple and usable interface
to build `UNION (DISTINCT)` and `UNION ALL` queries.

[1] https://github.com/doctrine/dbal/pull/6369
[2] https://github.com/doctrine/dbal/releases/tag/4.1.0

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 2857

Show 1532 earlier messages
  1. Stefan Bürk uploaded patch set 1 04/20/24, 14:59

  2. core-ci voted on patch set 1 V +1 04/20/24, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56386

  3. core-ci commented on patch set 1 04/20/24, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56387

  4. Stefan Bürk uploaded patch set 2 V +1 04/20/24, 15:26

  5. core-ci voted on patch set 2 V +1 04/20/24, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56388

  6. Stefan Bürk uploaded patch set 3 V +1 04/20/24, 15:50

  7. core-ci voted on patch set 3 V +1 04/20/24, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56389

  8. Stefan Bürk uploaded patch set 4 V +1 04/20/24, 16:05

  9. core-ci voted on patch set 4 V +1 04/20/24, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56390

  10. Stefan Bürk uploaded patch set 5 V +1 04/20/24, 16:19

  11. core-ci voted on patch set 5 V -1 04/20/24, 16:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56391

  12. core-ci voted on patch set 5 V +1 04/20/24, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56391

  13. core-ci commented on patch set 5 04/20/24, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56392

  14. Stefan Bürk updated the commit message in patch set 6 V +1 04/23/24, 14:52

  15. Stefan Bürk updated the commit message in patch set 7 04/23/24, 14:54

  16. core-ci voted on patch set 6 V +1 04/23/24, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56590

  17. core-ci voted on patch set 7 V +1 04/23/24, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56591

  18. Stefan Bürk uploaded patch set 8 V +1 04/26/24, 00:59

  19. core-ci voted on patch set 8 V -1 04/26/24, 01:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56723

  20. Stefan Bürk uploaded patch set 9 V -1 04/26/24, 11:11

  21. core-ci voted on patch set 9 V -1 04/26/24, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56775

  22. Stefan Bürk uploaded patch set 10 V -1 04/26/24, 13:12

  23. core-ci voted on patch set 10 V -1 04/26/24, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56781

  24. Stefan Bürk uploaded patch set 11 V -1 04/26/24, 13:21

  25. core-ci voted on patch set 11 V -1 04/26/24, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56782

  26. Stefan Bürk uploaded patch set 12 V -1 04/26/24, 13:28

  27. core-ci voted on patch set 12 V +1 04/26/24, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56784

  28. Stefan Bürk uploaded patch set 13 V +1 04/26/24, 13:54

  29. core-ci voted on patch set 13 V +1 04/26/24, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56787

  30. Stefan Bürk uploaded patch set 14 V +1 04/26/24, 18:56

  31. core-ci voted on patch set 14 V +1 04/26/24, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56798

  32. Stefan Bürk uploaded patch set 15 V +1 06/03/24, 14:07

  1. core-ci voted on patch set 15 V +1 06/03/24, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58620

  2. Stefan Bürk uploaded patch set 16 V +1 06/13/24, 10:59

  3. core-ci voted on patch set 16 V +1 06/13/24, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59465

  4. Stefan Bürk uploaded patch set 17 V +1 08/03/24, 08:47

  5. core-ci voted on patch set 17 V +1 08/03/24, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62791

  6. Stefan Bürk uploaded patch set 18 V +1 08/14/24, 14:13

  7. core-ci voted on patch set 18 V -1 08/14/24, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63392

  8. Stefan Bürk uploaded patch set 19 V -1 08/14/24, 17:41

  9. Stefan Bürk uploaded patch set 20 08/14/24, 17:49

  10. core-ci voted on patch set 19 V -1 08/14/24, 17:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63400

  11. core-ci voted on patch set 20 V +1 08/14/24, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63402

  12. Stefan Bürk rebased onto patch set 21 V +1 08/14/24, 20:03

  13. core-ci voted on patch set 21 V +1 08/14/24, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63414

  14. Stefan Bürk uploaded patch set 22 V +1 08/15/24, 11:48

  15. core-ci voted on patch set 22 V +1 08/15/24, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63473

  16. Stefan Bürk uploaded patch set 23 V +1 08/15/24, 14:47

  17. Stefan Bürk updated the commit message in patch set 24 08/15/24, 14:48

  18. core-ci voted on patch set 23 V +1 08/15/24, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63505

  19. core-ci voted on patch set 24 V +1 08/15/24, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63506

  20. Stefan Bürk uploaded patch set 25 V +1 08/15/24, 15:07

  21. core-ci voted on patch set 25 V -1 08/15/24, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63511

  22. core-ci voted on patch set 25 V +1 08/15/24, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63511

  23. Christian Kuhn voted on patch set 25 CR +1 V +1 08/15/24, 22:53

  24. Anja Leichsenring voted on patch set 25 CR +2 V +2 08/16/24, 13:07

  25. Anja Leichsenring merged patch set 26 08/16/24, 13:07