83944[BUGFIX] Mitigate invalid exit code for UpgradeWizard without updates
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/install/Classes/Command/Exception/WizardDoesNotNeedToMakeChangesException.phpnew+27 −0
- typo3/sysext/install/Classes/Command/Exception/WizardMarkedAsDoneException.phpnew+27 −0
- typo3/sysext/install/Classes/Command/Exception/WizardNotFoundException.phpnew+27 −0
- typo3/sysext/install/Classes/Command/UpgradeWizardRunCommand.php+46 −33
Review log 1827
Show 2 earlier messages
-
core-ci voted on patch set 1 V -1 04/21/24, 00:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56396
-
core-ci voted on patch set 2 V +1 04/21/24, 00:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56397
-
Stefan Bürk updated the commit message in patch set 3
V +104/21/24, 00:17 -
core-ci voted on patch set 3 V +1 04/21/24, 00:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56398
-
Garvin Hicking updated the commit message in patch set 4
V +104/21/24, 17:53 -
core-ci voted on patch set 4 V +1 04/21/24, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56437
-
Thomas Hohn voted on patch set 4 CR +1 04/23/24, 09:21
-
Christian Kuhn uploaded patch set 5
CR +1V +104/23/24, 12:50 -
core-ci voted on patch set 5 V +1 04/23/24, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56577
-
Christian Kuhn commented on patch set 5 CR -1 04/23/24, 12:58
stefan will change another detail. -
Stefan Bürk uploaded patch set 6
CR -1V +104/23/24, 14:31 -
core-ci voted on patch set 6 V +1 04/23/24, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56588
-
Stefan Bürk commented on patch set 6 04/23/24, 14:40
Reply
nullable return for the getWizard() was not reasonable to communicate different things, thus replaced it with concrete and handled exceptions. That makes that now cleaner and more understandable. -
Christian Kuhn commented on patch set 6 04/23/24, 15:31
WizardCreationError.php:18we often move exceptions to an own sub-folder, and exception classes always are like "SomethingException". i guess we should follow this scheme here as well? -
Stefan Bürk uploaded patch set 7
V +104/23/24, 16:17 -
Stefan Bürk commented on patch set 7 04/23/24, 16:17
WizardCreationError.php:18ReplyDone -
core-ci voted on patch set 7 V +1 04/23/24, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56593
-
Stefan Bürk uploaded patch set 8
V +104/23/24, 16:25 -
core-ci voted on patch set 8 V +1 04/23/24, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56594
-
Stefan Bürk uploaded patch set 9
V +104/23/24, 16:31 -
Christian Kuhn commented on patch set 9 CR +1 V +1 04/23/24, 16:32
Reply
Done -
core-ci voted on patch set 9 V +1 04/23/24, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56595
-
Benni Mack voted on patch set 9 CR +1 V +1 04/23/24, 20:18
-
Stefan Bürk voted on patch set 9 CR +2 V +2 04/23/24, 22:17
-
Stefan Bürk merged patch set 10 04/23/24, 22:30