Review 12.4 Merged

83946[BUGFIX] Ensure that relative target link can be set in EXT:redirects

Stefan Bürk CR +2 V +2 Normal +208 −6 updated 04/21/24, 11:48

Commit message

The TYPO3 system extension `redirects` now fully supports the setting
of relative links as the `target` URL, which is a documented feature.

Previously, an issue arose when attempting to use path links with
leading slashes as URLs. This issue has been addressed in #101083,
marking the initial step toward resolving the problem of relative
target links.

Additionally, the fix now allows for linking to arbitrary resources,
even those that do not currently exist in the File Abstraction Layer
(FAL).

The class `TYPO3\CMS\Core\LinkHandling\LegacyLinkNotationConverter`
has been changed to limit the handling of arbitrary resources
to the smallest scope to reuse existing code and to use them
as `LinkService::TYPE_URL` links.

The superflous outer catch block has been removed to remove
dead code. In addition, a test for coverage has been added
that covers DataHandler and the lower LinkHandling layer.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 7

Review log 34

  1. Stefan Bürk uploaded patch set 1 04/21/24, 11:41

  2. core-ci voted on patch set 1 V +1 04/21/24, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56423

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 04/21/24, 11:48

  4. Stefan Bürk merged patch set 2 04/21/24, 11:48