Review main Abandoned

83948[BUGFIX] Return `400 Bad Request` if request can't be created

Stefan Bürk CR 0 V 0 Easy +16 −2 updated 11/15/24, 09:51

Commit message

In cases where an invalid request is received, the TYPO3
internal creation of a request object as transport DTO
fails during creating it from PHP globals within the
`ServerRequestFactory::fromGlobals()` method.

This change modifies the `AbstractApplication::run()`
method and guard the request creation. For any error
occurring during creating the request, a more suitable
`400 Bad Request` response is returned.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 916

  1. Stefan Bürk uploaded patch set 1 04/21/24, 16:52

  2. Stefan Bürk updated the commit message in patch set 2 04/21/24, 16:53

  3. core-ci voted on patch set 1 V +1 04/21/24, 16:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56431

  4. core-ci voted on patch set 2 V +1 04/21/24, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56432

  5. Stefan Bürk uploaded patch set 3 V +1 04/21/24, 17:03

  6. core-ci voted on patch set 3 V -1 04/21/24, 17:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56433

  7. Oliver Klee updated the commit message in patch set 4 V -1 04/21/24, 17:20

  8. Oliver Klee updated the commit message in patch set 5 04/21/24, 17:20

  9. Oliver Klee commented on patch set 6 04/21/24, 17:21

    Published edit on patch set 5.
  10. core-ci voted on patch set 5 V +1 04/21/24, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56435

  11. core-ci voted on patch set 4 V +1 04/21/24, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56434

  12. core-ci voted on patch set 6 V +1 04/21/24, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56436

  13. Stefan Bürk commented on patch set 6 CR -1 04/21/24, 20:17

    Unresolved

    Narf - after providing this change, gerrit revealed a old WIP change doing that on a more conditional way, but stalled - already quite some time. See: 75613: [TASK] Directly respond to invalid HTTP server requests | https://review.typo3.org/c/Packages/TYPO3.CMS/+/75613
  14. Benni Mack updated the commit message in patch set 7 CR -1 V +1 10/18/24, 13:28

  15. core-ci voted on patch set 7 V -1 10/18/24, 21:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67971

  16. Benni Mack abandoned the change 11/15/24, 09:51