Review main Merged

83950[BUGFIX] Link root page title in site configuration module

Oli Bartsch CR +2 V +2 Easy +15 −3 updated 04/23/24, 20:50

Commit message

To be consistent with the other listings in the
backend is the root page title of a site in the
site configuration module now linked, allowing
to edit the corresponding site configuration.

Additionally does the link as well as the
edit button now use a dedicated label instead
of a generic one.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Oli Bartsch uploaded patch set 1 04/22/24, 07:39

  2. core-ci voted on patch set 1 V -1 04/22/24, 07:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56471

  3. Oli Bartsch uploaded patch set 2 V -1 04/22/24, 08:26

  4. core-ci voted on patch set 2 V +1 04/22/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56477

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 04/23/24, 08:59

  6. Christian Kuhn commented on patch set 2 04/23/24, 13:12

    pinged jasmina on this: iirc, this was clickable in the past and maybe jasmina removed this. let's get a statement from her.
  7. Jasmina Ließmann commented on patch set 2 04/23/24, 14:28

    Reply

    That's right, but this patch is fine for me.
  8. Jasmina Ließmann voted on patch set 2 CR +1 V +1 04/23/24, 14:29

  9. Oli Bartsch commented on patch set 2 04/23/24, 14:46

    Reply

    Thanks for the fast feedback.
  10. Oli Bartsch voted on patch set 2 CR +2 V +2 04/23/24, 20:50

  11. Oli Bartsch merged patch set 3 04/23/24, 20:50