Review main Merged

83956[TASK] Move FE rootline tests

Christian Kuhn CR +2 V +2 Hard +81 −199 updated 04/23/24, 06:24

Commit message

The rootline calculation has been moved around
with various patches in v12 & v13. Refactor some
related tests and move them to a more appropriate
place.
This also avoids another TSFE access in tests.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 4

Files 4

Review log 69

  1. Christian Kuhn uploaded patch set 1 04/22/24, 23:25

  2. core-ci voted on patch set 1 V -1 04/22/24, 23:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56515

  3. Christian Kuhn uploaded patch set 2 V -1 04/22/24, 23:31

  4. Christian Kuhn uploaded patch set 3 04/22/24, 23:33

  5. core-ci voted on patch set 2 V -1 04/22/24, 23:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56517

  6. core-ci voted on patch set 3 V +1 04/22/24, 23:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56518

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 04/23/24, 00:07

  8. Benjamin Franzke voted on patch set 3 CR +2 V +2 04/23/24, 06:24

  9. Benjamin Franzke merged patch set 4 04/23/24, 06:24