Review main Merged

83995[TASK] Migrate theme to light dark notation

Benjamin Kott CR +2 V +2 Normal +46 −135 updated 04/23/24, 08:54

Commit message

With new web standards arising and getting shipped to the web platform,
we are migrating the currently limited light and dark mode components to
the web native color-scheme.

See: https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme

Instead of relying on preferred color scheme queries, we're adopting the
light-dark color function, streamlining our CSS and ensuring compatibility
with all major browsers, except Safari (for now).

While Safari is slightly behind, we anticipate full support for
light-dark mode by May 2024, with the feature already available in
Safari 17.5 Beta.

See: https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/light-dark
See: https://developer.apple.com/documentation/safari-release-notes/safari-17_5-release-notes

Note:

Safari users will experience missing backgrounds and colors due to our
decision not address this behavior. We're forward-facing and planning
for the LTS release. If you intend to use Safari during development,
please ensure you're using at least Safari 17.5 Beta.

We're monitoring the situation closely and will implement a fallback if
Safari hasn't released a compatible version before 13.2.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Frank Nägler +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Frank Nägler +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1012

  1. Benjamin Kott uploaded patch set 1 04/23/24, 07:19

  2. Benjamin Kott updated the commit message in patch set 2 04/23/24, 08:34

  3. Benjamin Franzke commented on patch set 2 CR -1 04/23/24, 08:35

    function, see https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/light-dark > The light-dark() CSS <color> function enables setting two colors for a property
  4. Benjamin Franzke commented on patch set 2 04/23/24, 08:36

    "to not"?
  5. Benjamin Kott updated the commit message in patch set 3 CR -1 04/23/24, 08:37

  6. core-ci voted on patch set 2 V +1 04/23/24, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56554

  7. Benjamin Franzke commented on patch set 3 CR +1 V +1 04/23/24, 08:41

    Nice.

    Reply

    Done

    Reply

    Done
  8. core-ci voted on patch set 3 V +1 04/23/24, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56555

  9. Frank Nägler voted on patch set 3 CR +1 V +1 04/23/24, 08:51

  10. Andreas Kienast voted on patch set 3 CR +1 V +1 04/23/24, 08:53

  11. Benjamin Kott voted on patch set 3 CR +2 V +2 04/23/24, 08:54

  12. Benjamin Kott merged patch set 4 04/23/24, 08:54