Review main Merged

83998[BUGFIX] Make CE actions clickable after edit or visibility toggle

Ayke Halder CR +2 V +2 Easy +4 −18 updated 05/13/24, 16:09

Commit message

When a content element (CE) gets edited or the visibility is toggled,
the page module is reloaded with an anchor in the URL to scroll to the
content element that was updated.

After #103381 it was not possible anymore to click the "+ Content"
button above such CE. The reason is that a pseudo element
`:target:before` is generated with a specific height and margin to
overcome the height of the floating module docheader, overlaying the
CE action button.
In the patch mentioned before, `overflow: hidden` was removed to make
the `box-shadow` of the CE visible, finally causing this bug.

To solve this issue the pseudo element add it #97036 is replaced by the
CSS option scroll-padding-top. It incorperates the maximum docheader
size plus a slight margin that is slightly lower than the grid margin –
but not equal to – to move shadows of adjacent elements out of sight.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • André Buchmann +1
    • Ayke Halder +1
    • Willi Wehmeier +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • André Buchmann +1
    • Ayke Halder +1
    • Willi Wehmeier +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 1420

  1. Ayke Halder uploaded patch set 1 04/23/24, 08:41

  2. core-ci voted on patch set 1 V +1 04/23/24, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56556

  3. Oli Bartsch voted on patch set 1 CR +1 V +1 04/23/24, 13:54

  4. Ayke Halder uploaded patch set 2 CR +1 V +1 05/13/24, 09:28

  5. core-ci voted on patch set 2 V +1 05/13/24, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57595

  6. Benjamin Franzke commented on patch set 2 CR -1 05/13/24, 11:18

    We should try to avoid adding workarounds to workarounds and use `scroll-padding-top`. Will provide a patch.
  7. Benjamin Franzke uploaded patch set 3 CR -1 V +1 05/13/24, 11:29

  8. Benjamin Franzke commented on patch set 3 05/13/24, 11:29

    Reply

    Done
  9. core-ci voted on patch set 3 V -1 05/13/24, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57612

  10. Ayke Halder rebased onto patch set 4 CR +1 V +1 05/13/24, 12:17

  11. Ayke Halder uploaded patch set 5 05/13/24, 12:17

  12. core-ci voted on patch set 4 V -1 05/13/24, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57617

  13. core-ci voted on patch set 5 V +1 05/13/24, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57618

  14. Ayke Halder uploaded patch set 6 05/13/24, 12:30

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  15. core-ci voted on patch set 6 V +1 05/13/24, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57619

  16. Ayke Halder voted on patch set 6 CR +1 V +1 05/13/24, 12:37

  17. Willi Wehmeier voted on patch set 6 CR +1 V +1 05/13/24, 12:55

  18. André Buchmann voted on patch set 6 CR +1 V +1 05/13/24, 13:33

  19. Benjamin Franzke voted on patch set 6 CR +2 V +2 05/13/24, 15:48

  20. Benjamin Franzke merged patch set 7 05/13/24, 16:09