Review main Merged

84001[TASK] Remove left over refindex _FILE handling

Christian Kuhn CR +2 V +2 Normal +17 −48 updated 04/23/24, 13:14

Commit message

ReferenceIndex does not write rows with
'ref_table' set to '_FILE' anymore since #87428.
The patch removes some left over handling at
a couple of places.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 7

Review log 1013

  1. Christian Kuhn uploaded patch set 1 04/23/24, 10:14

  2. core-ci voted on patch set 1 V -1 04/23/24, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56560

  3. Oliver Klee commented on patch set 1 04/23/24, 10:26

    BackendUtility.php:2524

    This probably needs to be either `string` or `string|int`. Otherwise, we wouldn't need the `canBeInterpretedAsInteger` call.
  4. Christian Kuhn commented on patch set 1 04/23/24, 10:40

    BackendUtility.php:2524 Reply

    it's for b/w compat. i can add a comment.
  5. Christian Kuhn uploaded patch set 2 V -1 04/23/24, 10:42

  6. Christian Kuhn commented on patch set 2 04/23/24, 10:43

    BackendUtility.php:2524 Reply

    background: the method should be deprecated at some point altogether. that's why i'm not type hinting the signature now - to avoid breaking it when we'll get rid of it anyways.
  7. core-ci voted on patch set 2 V -1 04/23/24, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56563

  8. Christian Kuhn uploaded patch set 3 V -1 04/23/24, 11:04

  9. core-ci voted on patch set 3 V +1 04/23/24, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56567

  10. Stefan Bürk voted on patch set 3 CR +1 V +1 04/23/24, 11:12

  11. Jochen Roth voted on patch set 3 CR +1 V +1 04/23/24, 13:02

  12. Christian Kuhn voted on patch set 3 CR +2 V +2 04/23/24, 13:14

  13. Christian Kuhn merged patch set 4 04/23/24, 13:14