Review 11.5 Merged

84003[BUGFIX] Avoid mapping route values that are out of scope

Oliver Hader CR +2 V +2 Normal +114 −6 updated 04/23/24, 11:20

Commit message

Given a static route argument mapper is used - for instance one
that allows values in the range of 1 to 100 - then generating an
URL from a route with an out of scope `&value=5000` was still
generating an URL. However, HTTP request to that URL would
result in an 404 error.

This change skips routes using out of scope values during the
URL generation process to avoid pointing to invalid resources.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Oliver Hader uploaded patch set 1 04/23/24, 10:59

  2. Oliver Hader voted on patch set 1 CR +2 V +2 04/23/24, 11:11

  3. Oliver Hader voted on patch set 1 CR 0 V 0 04/23/24, 11:11

  4. Oliver Hader voted on patch set 1 CR +2 V +2 04/23/24, 11:16

  5. core-ci voted on patch set 1 V +1 04/23/24, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56565

  6. Oliver Hader merged patch set 2 04/23/24, 11:20