Review 12.4 Merged

84005[TASK] Unify Rollup usage in frontend tooling

Benjamin Franzke CR +2 V +2 Hard +186 −220 updated 04/23/24, 14:32

Commit message

In the current frontend tooling, we invoke Rollup twice:

* via grunt-rollup to build library modules
* via the command line to build everything related to CKEditor

This commit gets rid of the first way and moves the library
compilation to a JS-backed configuration as well, so we can
get rid of a grunt package and also unify the tooling a bit.
We also make use of @rollup/plugin-terser instead of the deprecated
rollup-plugin-terser module that was used in ckeditor build before.

To match the new behaviour, the "exec:ckeditor" task also was
renamed to "exec:rollup".

Executed commands:

    npm remove grunt-rollup
    npm remove rollup-plugin-terser
    npm install @rollup/plugin-terser --save-dev
    npm run build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 19

Review log 69

  1. Benjamin Franzke uploaded patch set 1 04/23/24, 11:54

  2. core-ci voted on patch set 1 V -1 04/23/24, 12:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56573

  3. Andreas Kienast commented on patch set 1 CR -1 04/23/24, 13:01

    select-pure doesn't exist in v12
  4. Andreas Kienast uploaded patch set 2 CR -1 V -1 04/23/24, 14:12

  5. core-ci voted on patch set 2 V -1 04/23/24, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56583

  6. Benjamin Franzke uploaded patch set 3 V -1 04/23/24, 14:24

  7. core-ci voted on patch set 3 V +1 04/23/24, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56586

  8. Benjamin Franzke voted on patch set 3 CR +2 V +2 04/23/24, 14:31

  9. Benjamin Franzke merged patch set 4 04/23/24, 14:32