Review main Merged

84006[TASK] Remove usage of "newer" in grunt build

Andreas Kienast CR +2 V +2 Normal +24 −54 updated 04/24/24, 07:28

Commit message

The grunt module `grunt-newer` was introduced with #90200 to help
improving build times on consecutive single builds by running tasks on
changed files only.

This is nowadays not required anymore in JS build context, as it's
possible in TypeScript to compile changed files only, which is already
incorporated for quite a while. Therefore, the usage of `newer` is now
removed in this context. However, to avoid running `terser` multiple
times on the same, previously compiled files, the directory
`Build/JavaScript` now gets removed before each TypeScript compilation.

The postcss calculation is fast enough to not require grunt-newer at
all, therefore grunt-newer is dropped here as well.

Executed commands:

    npm remove grunt-newer

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 69

  1. Andreas Kienast uploaded patch set 1 04/23/24, 12:31

  2. core-ci voted on patch set 1 V +1 04/23/24, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56575

  3. Benjamin Franzke uploaded patch set 2 V +1 04/24/24, 06:58

  4. core-ci voted on patch set 2 V +1 04/24/24, 07:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56641

  5. Benjamin Franzke uploaded patch set 3 CR +1 V +1 04/24/24, 07:10

  6. core-ci voted on patch set 3 V +1 04/24/24, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56642

  7. Benjamin Kott voted on patch set 3 CR +1 V +1 04/24/24, 07:19

  8. Andreas Kienast voted on patch set 3 CR +2 V +2 04/24/24, 07:20

  9. Andreas Kienast merged patch set 4 04/24/24, 07:28