Review main Merged

84010[TASK] Show information text as infobox in "Workspaces" backend module

Jasmina Ließmann CR +2 V +2 Easy +5 −4 updated 04/23/24, 20:28

Commit message

If no record was found in "Workspaces" backend module, an information
is displayed. This text is now displayed in the typical infobox style
instead of with specific Bootstrap styling classes.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Jasmina Ließmann uploaded patch set 1 04/23/24, 17:40

  2. core-ci voted on patch set 1 V +1 04/23/24, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56599

  3. Christian Kuhn commented on patch set 1 04/23/24, 17:55

    locallang.xlf:10

    maybe improve the message along the way? Something like "No records changed in workspaces found.", or no need?
  4. Jasmina Ließmann commented on patch set 1 04/23/24, 17:58

    locallang.xlf:10 Reply

    I thought about that too, but the message also appears if the search using the search field doesn't return any entries. Therefore I would keep the existing message.
  5. Christian Kuhn commented on patch set 1 CR +1 V +1 04/23/24, 18:31

    locallang.xlf:10 Reply

    Acknowledged
  6. Benni Mack voted on patch set 1 CR +1 V +1 04/23/24, 20:16

  7. Jasmina Ließmann voted on patch set 1 CR +2 V +2 04/23/24, 20:28

  8. Jasmina Ließmann merged patch set 2 04/23/24, 20:28