84011[BUGFIX] Add missing hover style to link in "Access" backend module
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2127
Show 2 earlier messages
-
core-ci voted on patch set 1 V +1 04/23/24, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56602
-
Jasmina Ließmann updated the commit message in patch set 2
V +104/23/24, 18:19 -
Jasmina Ließmann updated the commit message in patch set 3 04/23/24, 18:24
-
core-ci voted on patch set 2 V +1 04/23/24, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56603
-
core-ci voted on patch set 3 V +1 04/23/24, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56604
-
Christian Kuhn commented on patch set 3 04/23/24, 18:33
Index.html:47editUrl has spaces in it? why? couldn't we get rid of that somehow? -
Jasmina Ließmann commented on patch set 3 04/23/24, 18:34
Index.html:47ReplyIt's because of the linebreaks in the <f:variable /> lines. Eitjer inline styles or write it all in one line would help, but not really improve readability. -
Jasmina Ließmann commented on patch set 3 04/23/24, 18:39
Index.html:47ReplyOther possibility could be to reassign the variable via `<f:variable name="editUrl" value="{editUrl -> f:spaceless()}" />`. -
Ayke Halder commented on patch set 3 04/23/24, 18:50
Index.html:47ReplyHow about setting the variable itself like: ```xml <f:variable name="editUrl"><backend:moduleLink route="permissions_pages" arguments="{id: '{f:if(condition: data.row._ORIG_uid, then: data.row._ORIG_uid, else: data.row.uid)}', action: 'edit', depth: depth, returnUrl: returnUrl}" /></f:variable> ``` Or as alternative: ```xml <f:variable name="editUrl"><f:spaceless> <backend:moduleLink route="permissions_pages" arguments="{id: '{f:if(condition: data.row._ORIG_uid, then: data.row._ORIG_uid, else: data.row.uid)}', action: 'edit', depth: depth, returnUrl: returnUrl}"/> </f:spaceless></f:variable> ``` -
Jasmina Ließmann uploaded patch set 4
V +104/26/24, 10:18 -
Jasmina Ließmann commented on patch set 4 04/26/24, 10:19
Index.html:47ReplyDone -
core-ci voted on patch set 4 V +1 04/26/24, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56768
-
Ayke Halder commented on patch set 4 04/26/24, 10:44
Index.html:45The icon is now outside the link-tag and thereby not clickable anymore. Is this an intended change? -
Jasmina Ließmann commented on patch set 4 04/26/24, 10:48
Index.html:45ReplyYes. The click on the icon is usually related to the click menu - you can see this in multiple places in the backend - for example in the "Localization overview" of the "Info" module. -
Jasmina Ließmann commented on patch set 4 04/26/24, 10:53
Index.html:45ReplyWill add the contextmenu on the icon later with a different patch. -
Ayke Halder commented on patch set 4 04/26/24, 11:08
Index.html:45ReplyThis now introduces mouse pointer change to cursor - caused by whitespaces: See https://forge.typo3.org/issues/103715#note-5 -
Jasmina Ließmann uploaded patch set 5
V +104/26/24, 18:34 -
Jasmina Ließmann uploaded patch set 6 04/26/24, 18:37
-
core-ci voted on patch set 5 V +1 04/26/24, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56796
-
core-ci voted on patch set 6 V +1 04/26/24, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56797
-
Jasmina Ließmann commented on patch set 6 04/26/24, 18:44
Index.html:45ReplyI added a <f:spaceless() /> around the tree line and page icon. But avoided including the link as it creates unwanted visual effects. I think the cursor change between treeline and page icons should be considered separately as this can also occur with other views/modules. -
Christian Kuhn commented on patch set 6 CR +1 V +1 04/26/24, 22:20
Index.html:45Replyyeah. that makes the gap between tree icon and page icon smaller, and is probably what it should look like. adding a clickmenu to the icon could be done with another patch. the cursor thingie happens in various similar ways at other places, too, i guess we should keep that for now.Index.html:47Replythx. don't like it too much, but it does not kill kitten, either. -
Stefan Bürk voted on patch set 6 CR +1 V +1 04/28/24, 18:15
-
Jasmina Ließmann voted on patch set 6 CR +2 V +2 04/29/24, 16:25
-
Jasmina Ließmann merged patch set 7 04/29/24, 16:25