Review main Merged

84011[BUGFIX] Add missing hover style to link in "Access" backend module

Jasmina Ließmann CR +2 V +2 Easy +8 −11 updated 04/29/24, 16:25

Commit message

The title of the linked page was missing a hover style, which is now
ensured with this patch. An appropriate link title is also added.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2127

Show 2 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 04/23/24, 18:14

  2. Jasmina Ließmann commented on patch set 1 04/23/24, 18:17

    Note: The module requires further adjustments, which will be made with further patches.
  1. core-ci voted on patch set 1 V +1 04/23/24, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56602

  2. Jasmina Ließmann updated the commit message in patch set 2 V +1 04/23/24, 18:19

  3. Jasmina Ließmann updated the commit message in patch set 3 04/23/24, 18:24

  4. core-ci voted on patch set 2 V +1 04/23/24, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56603

  5. core-ci voted on patch set 3 V +1 04/23/24, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56604

  6. Christian Kuhn commented on patch set 3 04/23/24, 18:33

    Index.html:47

    editUrl has spaces in it? why? couldn't we get rid of that somehow?
  7. Jasmina Ließmann commented on patch set 3 04/23/24, 18:34

    Index.html:47 Reply

    It's because of the linebreaks in the <f:variable /> lines. Eitjer inline styles or write it all in one line would help, but not really improve readability.
  8. Jasmina Ließmann commented on patch set 3 04/23/24, 18:39

    Index.html:47 Reply

    Other possibility could be to reassign the variable via `<f:variable name="editUrl" value="{editUrl -> f:spaceless()}" />`.
  9. Ayke Halder commented on patch set 3 04/23/24, 18:50

    Index.html:47 Reply

    How about setting the variable itself like: ```xml <f:variable name="editUrl"><backend:moduleLink route="permissions_pages" arguments="{id: '{f:if(condition: data.row._ORIG_uid, then: data.row._ORIG_uid, else: data.row.uid)}', action: 'edit', depth: depth, returnUrl: returnUrl}" /></f:variable> ``` Or as alternative: ```xml <f:variable name="editUrl"><f:spaceless> <backend:moduleLink route="permissions_pages" arguments="{id: '{f:if(condition: data.row._ORIG_uid, then: data.row._ORIG_uid, else: data.row.uid)}', action: 'edit', depth: depth, returnUrl: returnUrl}"/> </f:spaceless></f:variable> ```
  10. Jasmina Ließmann uploaded patch set 4 V +1 04/26/24, 10:18

  11. Jasmina Ließmann commented on patch set 4 04/26/24, 10:19

    Index.html:47 Reply

    Done
  12. core-ci voted on patch set 4 V +1 04/26/24, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56768

  13. Ayke Halder commented on patch set 4 04/26/24, 10:44

    Index.html:45

    The icon is now outside the link-tag and thereby not clickable anymore. Is this an intended change?
  14. Jasmina Ließmann commented on patch set 4 04/26/24, 10:48

    Index.html:45 Reply

    Yes. The click on the icon is usually related to the click menu - you can see this in multiple places in the backend - for example in the "Localization overview" of the "Info" module.
  15. Jasmina Ließmann commented on patch set 4 04/26/24, 10:53

    Index.html:45 Reply

    Will add the contextmenu on the icon later with a different patch.
  16. Ayke Halder commented on patch set 4 04/26/24, 11:08

    Index.html:45 Reply

    This now introduces mouse pointer change to cursor - caused by whitespaces: See https://forge.typo3.org/issues/103715#note-5
  17. Jasmina Ließmann uploaded patch set 5 V +1 04/26/24, 18:34

  18. Jasmina Ließmann uploaded patch set 6 04/26/24, 18:37

  19. core-ci voted on patch set 5 V +1 04/26/24, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56796

  20. core-ci voted on patch set 6 V +1 04/26/24, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56797

  21. Jasmina Ließmann commented on patch set 6 04/26/24, 18:44

    Index.html:45 Reply

    I added a <f:spaceless() /> around the tree line and page icon. But avoided including the link as it creates unwanted visual effects. I think the cursor change between treeline and page icons should be considered separately as this can also occur with other views/modules.
  22. Christian Kuhn commented on patch set 6 CR +1 V +1 04/26/24, 22:20

    Index.html:45 Reply

    yeah. that makes the gap between tree icon and page icon smaller, and is probably what it should look like. adding a clickmenu to the icon could be done with another patch. the cursor thingie happens in various similar ways at other places, too, i guess we should keep that for now.

    Index.html:47 Reply

    thx. don't like it too much, but it does not kill kitten, either.
  23. Stefan Bürk voted on patch set 6 CR +1 V +1 04/28/24, 18:15

  24. Jasmina Ließmann voted on patch set 6 CR +2 V +2 04/29/24, 16:25

  25. Jasmina Ließmann merged patch set 7 04/29/24, 16:25