84014[BUGFIX] Migrate Bootstrap progress bars to bootstrap 5.3
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Andreas Nedbal +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Andreas Nedbal +1
- core-ci +1 CI
Issues 1
Files 18
- Build/Sources/TypeScript/backend/login-refresh.ts+7 −6
- Build/Sources/TypeScript/backend/multi-step-wizard.ts+28 −16
- Build/Sources/TypeScript/backend/wizard.ts+21 −16
- Build/Sources/TypeScript/install/module/upgrade/extension-scanner.ts+8 −3
- Build/Sources/TypeScript/install/module/upgrade/upgrade-wizards.ts+4 −3
- Build/Sources/TypeScript/install/renderable/progress-bar.ts+3 −3
- Build/Sources/TypeScript/install/installer.ts+7 −5
- typo3/sysext/backend/Resources/Public/JavaScript/login-refresh.js+7 −6
- typo3/sysext/backend/Resources/Public/JavaScript/multi-step-wizard.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/wizard.js+1 −1
- typo3/sysext/install/Resources/Private/Templates/Installer/MainLayout.html+2 −2
- typo3/sysext/install/Resources/Private/Templates/Upgrade/ExtensionScanner.html+2 −2
- typo3/sysext/install/Resources/Private/Templates/Upgrade/UpgradeWizards.html+2 −6
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/extension-scanner.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/upgrade-wizards.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/renderable/progress-bar.js+4 −4
- typo3/sysext/install/Resources/Public/JavaScript/installer.js+1 −1
- typo3/sysext/scheduler/Resources/Private/Partials/TaskList.html+2 −2
Review log 2023
-
Andreas Kienast uploaded patch set 1 04/24/24, 10:01
-
core-ci voted on patch set 1 V +1 04/24/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56647
-
Andreas Kienast uploaded patch set 2
V +104/24/24, 10:09 -
core-ci voted on patch set 2 V +1 04/24/24, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56650
-
Andreas Kienast commented on patch set 2 CR -1 04/24/24, 10:15
Multi Step Wizard needs a minor adjustment -
Andreas Kienast commented on patch set 2 CR 0 04/24/24, 10:31
Reply
Cannot be solved right now. The MSW component fakes a "stepped" progress bar by visually "glueing" multiple progress bars which now conflicts with the changes proposed by Bootstrap. This needs a mid-term solution. -
Simon Schaufelberger commented on patch set 2 04/24/24, 11:02
why is this a BUGFIX? should it not be a task? -
Andreas Kienast commented on patch set 2 04/24/24, 11:05
Reply
Because we don't use proper markup anymore since we upgraded to Bootstrap 5.3. -
Simon Schaufelberger commented on patch set 2 04/24/24, 11:29
Reply
Then it would be good to have a clearer forge issue because it doesn't tell anything what exactly is broken. Also some steps to reproduce would be good or some screenshots or whatever. -
Simon Schaufelberger commented on patch set 2 04/24/24, 11:29
Reply
anything that would help me to review this patch -
Andreas Kienast commented on patch set 2 04/24/24, 11:32
Reply
I've linked the changelog of Bootstrap in the ticket and in the patch that already explains the necessity for this change. -
Benjamin Franzke commented on patch set 2 04/24/24, 11:37
Reply
Please think about your words. This sounds quite rude – maybe you should question yourself, if you read the provided information carefully. The ticket and patch description contain the necessary information: "has changed for accessibility reasons" with a link to the bootstrap documentation: https://getbootstrap.com/docs/5.3/migration/#progress-bars The first sentence in that link explains the reason why this is a correct BUGFIX and not just a TASK: > The markup for progress bars has been updated in v5.3.0. Due to the placement of role and various aria- attributes on the inner .progress-bar element, some screen readers were not announcing zero value progress bars. -
Simon Schaufelberger commented on patch set 2 04/24/24, 11:49
Reply
I'm really sorry if you got the impression that I was rude. I'm just trying to review this patch but I find it quite difficult to verify this patch. It would be better for me to have a list for example of places I can check like: - Scheduler - Install tool xxx - ... I have no idea where this progress bar is currently used. -
Benjamin Franzke voted on patch set 2 CR +1 V +1 04/25/24, 06:48
-
Simon Schaufelberger wrote 04/25/24, 07:04
Removed cc Simon Schaufelberger. -
Andreas Nedbal voted on patch set 2 CR +1 V +1 04/26/24, 10:53
-
Andreas Kienast voted on patch set 2 CR +2 V +2 04/28/24, 11:22
-
Andreas Kienast rebased onto patch set 3
CR +1V +104/28/24, 11:40 -
Andreas Nedbal voted on patch set 3 CR +1 V +1 04/28/24, 11:41
-
core-ci voted on patch set 3 V +1 04/28/24, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56911
-
Benjamin Franzke voted on patch set 3 CR +1 V +1 04/28/24, 14:11
-
Andreas Kienast voted on patch set 3 CR +2 V +2 04/28/24, 14:28
-
Andreas Kienast merged patch set 4 04/28/24, 14:28