Review main Merged

84014[BUGFIX] Migrate Bootstrap progress bars to bootstrap 5.3

Andreas Kienast CR +2 V +2 Normal +102 −79 updated 04/28/24, 14:28

Commit message

With the update of Bootstrap to v5.3, the implementation of progress
bars has changed for accessibility reasons [1].

This commit updates all usages of progress bars to the new markup.

[1] https://getbootstrap.com/docs/5.3/migration/#progress-bars

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 2023

  1. Andreas Kienast uploaded patch set 1 04/24/24, 10:01

  2. core-ci voted on patch set 1 V +1 04/24/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56647

  3. Andreas Kienast uploaded patch set 2 V +1 04/24/24, 10:09

  4. core-ci voted on patch set 2 V +1 04/24/24, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56650

  5. Andreas Kienast commented on patch set 2 CR -1 04/24/24, 10:15

    Multi Step Wizard needs a minor adjustment
  6. Andreas Kienast commented on patch set 2 CR 0 04/24/24, 10:31

    Reply

    Cannot be solved right now. The MSW component fakes a "stepped" progress bar by visually "glueing" multiple progress bars which now conflicts with the changes proposed by Bootstrap. This needs a mid-term solution.
  7. Simon Schaufelberger commented on patch set 2 04/24/24, 11:02

    why is this a BUGFIX? should it not be a task?
  8. Andreas Kienast commented on patch set 2 04/24/24, 11:05

    Reply

    Because we don't use proper markup anymore since we upgraded to Bootstrap 5.3.
  9. Simon Schaufelberger commented on patch set 2 04/24/24, 11:29

    Reply

    Then it would be good to have a clearer forge issue because it doesn't tell anything what exactly is broken. Also some steps to reproduce would be good or some screenshots or whatever.
  10. Simon Schaufelberger commented on patch set 2 04/24/24, 11:29

    Reply

    anything that would help me to review this patch
  11. Andreas Kienast commented on patch set 2 04/24/24, 11:32

    Reply

    I've linked the changelog of Bootstrap in the ticket and in the patch that already explains the necessity for this change.
  12. Benjamin Franzke commented on patch set 2 04/24/24, 11:37

    Reply

    Please think about your words. This sounds quite rude – maybe you should question yourself, if you read the provided information carefully. The ticket and patch description contain the necessary information: "has changed for accessibility reasons" with a link to the bootstrap documentation: https://getbootstrap.com/docs/5.3/migration/#progress-bars The first sentence in that link explains the reason why this is a correct BUGFIX and not just a TASK: > The markup for progress bars has been updated in v5.3.0. Due to the placement of role and various aria- attributes on the inner .progress-bar element, some screen readers were not announcing zero value progress bars.
  13. Simon Schaufelberger commented on patch set 2 04/24/24, 11:49

    Reply

    I'm really sorry if you got the impression that I was rude. I'm just trying to review this patch but I find it quite difficult to verify this patch. It would be better for me to have a list for example of places I can check like: - Scheduler - Install tool xxx - ... I have no idea where this progress bar is currently used.
  14. Benjamin Franzke voted on patch set 2 CR +1 V +1 04/25/24, 06:48

  15. Simon Schaufelberger wrote 04/25/24, 07:04

    Removed cc Simon Schaufelberger.
  16. Andreas Nedbal voted on patch set 2 CR +1 V +1 04/26/24, 10:53

  17. Andreas Kienast voted on patch set 2 CR +2 V +2 04/28/24, 11:22

  18. Andreas Kienast rebased onto patch set 3 CR +1 V +1 04/28/24, 11:40

  19. Andreas Nedbal voted on patch set 3 CR +1 V +1 04/28/24, 11:41

  20. core-ci voted on patch set 3 V +1 04/28/24, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56911

  21. Benjamin Franzke voted on patch set 3 CR +1 V +1 04/28/24, 14:11

  22. Andreas Kienast voted on patch set 3 CR +2 V +2 04/28/24, 14:28

  23. Andreas Kienast merged patch set 4 04/28/24, 14:28