Review main Merged

84015[TASK] Avoid direct MySQL mention in README.md

TYPO3com CR +2 V +2 Easy +1 −1 updated 05/25/24, 20:57

Commit message

TYPO3 works with various DBMS. Avoid a specific
mention of MySQL in README.md, the version matrix
reveals details.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. TYPO3com uploaded patch set 1 04/24/24, 10:30

  2. core-ci voted on patch set 1 V +1 04/24/24, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56653

  3. Garvin Hicking commented on patch set 1 04/24/24, 11:42

    README.md:12

    I'd argue that if we begin to name more than only one example, we should expand it to the full list, and mention SQLite and PostgreSQL too. Then again, having 4 database types listed at this point kills the reading flow. Strictly speaking, a database server isn't even needed because SQLite would work without one. My suggestion would be either: ``` TYPO3 requires a web server with PHP and a suitable database server. The backend is accessed via a supported browser. For detailed software requirements and instructions on how to set up a basic TYPO3 installation, plese see the [Installation Guide](https://docs.typo3.org/installation) ``` or ``` TYPO3 requires a web server with PHP. The backend is accessed via supported browsers. For detailed software requirements and instructions on how to set up a basic TYPO3 installation, plese see the [Installation Guide](https://docs.typo3.org/installation) ```
  4. Stefan Bürk commented on patch set 1 04/24/24, 19:12

    README.md:12 Reply

    Strictly speaking it would require to mention supported version matrix, which is even more not reasonable. I'd suggest to remove any naming and refer to the general requirements. Instead of `database server` we could refer to `suitable database system` which targets the server-less SQlite and the server based. Omitting it completly could introduce the believe that no database is required at all, which is wrong. Summed up, the original (e.g.) already tated a example and not all posible values. Beside that, MySQL and MariaDB are no drop-in replacements anymore (not fully).
  5. Garvin Hicking commented on patch set 1 CR -1 05/24/24, 11:54

    README.md:12 Reply

    I'd opt to close this?
  6. Christian Kuhn commented on patch set 1 05/25/24, 13:00

    README.md:12 Reply

    let's just remove the parenthesis.
  7. Christian Kuhn uploaded patch set 2 CR -1 V +1 05/25/24, 13:02

  8. Christian Kuhn commented on patch set 2 CR +1 V +1 05/25/24, 13:03

    README.md:12 Reply

    done. fine with you?
  9. core-ci voted on patch set 2 V +1 05/25/24, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58218

  10. Garvin Hicking commented on patch set 2 CR +1 V +1 05/25/24, 14:05

    I could also just keep it as is, but that works for me if you want :-)

    README.md:12 Reply

    Acknowledged
  11. Stefan Bürk voted on patch set 2 CR +2 V +2 05/25/24, 16:19

  12. Georg Ringer voted on patch set 2 CR +1 V +1 05/25/24, 17:16

  13. Stefan Bürk merged patch set 3 05/25/24, 20:57