84019[TASK] Streamline Shadows
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 27
- Build/Sources/Sass/component/_card.scss+1 −1
- Build/Sources/Sass/component/_contextmenu.scss+1 −1
- Build/Sources/Sass/component/_datetimepicker.scss+1 −1
- Build/Sources/Sass/component/_example.scss+4 −1
- Build/Sources/Sass/component/_resources.scss+1 −1
- Build/Sources/Sass/component/_root.scss4+32 −2
- Build/Sources/Sass/component/_statusreport.scss+1 −1
- Build/Sources/Sass/component/_tree.scss1+2 −1
- Build/Sources/Sass/dashboard/_button.scss+1 −0
- Build/Sources/Sass/dashboard/_header.scss+1 −0
- Build/Sources/Sass/dashboard/_widget.scss+1 −1
- Build/Sources/Sass/dashboard_modal/_modal.scss+1 −1
- Build/Sources/Sass/element/typo3-notification-message.scss+1 −1
- Build/Sources/Sass/module/_page.scss+1 −2
- Build/Sources/Sass/module/_viewpage.scss+1 −1
- Build/Sources/Sass/typo3/structure/_module_file_filelist.scss+4 −4
- Build/Sources/Sass/typo3/_element_page_position.scss+1 −2
- Build/Sources/Sass/typo3/_main_backend_layout_wizard.scss+1 −1
- Build/Sources/Sass/variables/_dashboard.scss+0 −2
- Build/Sources/Sass/variables/_main.scss+5 −2
Show 7 more files
- typo3/sysext/backend/Resources/Public/Css/backend.css+20 −19
- typo3/sysext/dashboard/Resources/Public/Css/Modal/style.css+1 −1
- typo3/sysext/dashboard/Resources/Public/Css/dashboard.css+3 −3
- typo3/sysext/styleguide/Classes/Controller/BackendController.php+12 −0
- typo3/sysext/styleguide/Classes/ViewHelpers/CodeViewHelper.php+10 −3
- typo3/sysext/styleguide/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Shadows.htmlnew+54 −0
Review log 1931
Show 36 earlier messages
-
Benjamin Kott uploaded patch set 1 04/25/24, 06:50
-
core-ci voted on patch set 1 V +1 04/25/24, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56689
-
Benjamin Kott uploaded patch set 2
V +104/25/24, 08:41 -
core-ci voted on patch set 2 V +1 04/25/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56692
-
Benjamin Kott uploaded patch set 3
V +104/25/24, 09:07 -
core-ci voted on patch set 3 V -1 04/25/24, 09:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56693
-
Benjamin Kott uploaded patch set 4
V -104/25/24, 13:10 -
Benjamin Kott updated the commit message in patch set 5 04/25/24, 13:10
-
Benjamin Kott updated the commit message in patch set 6 04/25/24, 13:11
-
Benjamin Kott commented on patch set 6 CR -1 04/25/24, 13:15
missing stlyeguide demos -
core-ci voted on patch set 4 V +1 04/25/24, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56704
-
core-ci voted on patch set 5 V +1 04/25/24, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56705
-
core-ci voted on patch set 6 V +1 04/25/24, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56706
-
Benjamin Kott uploaded patch set 7
CR -1V +104/25/24, 13:56 -
core-ci voted on patch set 7 V -1 04/25/24, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56708
-
Benjamin Kott uploaded patch set 8
V -104/26/24, 05:46 -
core-ci voted on patch set 8 V +1 04/26/24, 05:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56746
-
Benjamin Kott uploaded patch set 9
V +104/26/24, 06:05 -
core-ci voted on patch set 9 V +1 04/26/24, 06:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56747
-
Benjamin Franzke commented on patch set 8 04/26/24, 06:14
_root.scss:31I think this is not quite right. Light-and-dark ortdering is switched. Dark needs darker shadows, yes, but first always needs to be the lower value._root.scss:35I think we need to differentiate offset-y for first and second shadow. One needs to be linear (to express elevation), while the other one should be rather static (to behave as key-shadow)._tree.scss:369^^ -
Benjamin Franzke uploaded patch set 10
V +104/26/24, 06:53 -
Benjamin Franzke uploaded patch set 11 04/26/24, 06:58
-
Benjamin Franzke commented on patch set 11 04/26/24, 06:58
_root.scss:31ReplyDone_root.scss:35ReplyDone -
core-ci voted on patch set 10 V -1 04/26/24, 06:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56748
-
Benjamin Franzke uploaded patch set 12 04/26/24, 07:03
-
core-ci voted on patch set 11 V -1 04/26/24, 07:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56749
-
core-ci voted on patch set 12 V +1 04/26/24, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56750
-
Benjamin Franzke voted on patch set 12 CR +1 V +1 04/26/24, 07:09
-
Andreas Kienast voted on patch set 12 CR +1 V +1 04/26/24, 07:18
-
Benjamin Kott voted on patch set 12 CR +2 V +2 04/26/24, 07:18
-
Benjamin Kott merged patch set 13 04/26/24, 07:18