Review main Merged

84019[TASK] Streamline Shadows

Benjamin Kott CR +2 V +2 Normal +164 −52 updated 04/26/24, 07:18

Commit message

We're enhancing our backend by introducing a refined system for shadows.
The default and strong shadows remain for simple components, while
tooltips, flyouts, dialogs, and windows have dedicated ones.

This streamlines shadow definitions across elements, ensuring
consistency. Shadows support both light and dark modes for visibility
across all settings.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 27

Show 7 more files

Review log 1931

Show 36 earlier messages
  1. Benjamin Kott uploaded patch set 1 04/25/24, 06:50

  2. core-ci voted on patch set 1 V +1 04/25/24, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56689

  3. Benjamin Kott uploaded patch set 2 V +1 04/25/24, 08:41

  4. core-ci voted on patch set 2 V +1 04/25/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56692

  5. Benjamin Kott uploaded patch set 3 V +1 04/25/24, 09:07

  6. core-ci voted on patch set 3 V -1 04/25/24, 09:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56693

  1. Benjamin Kott uploaded patch set 4 V -1 04/25/24, 13:10

  2. Benjamin Kott updated the commit message in patch set 5 04/25/24, 13:10

  3. Benjamin Kott updated the commit message in patch set 6 04/25/24, 13:11

  4. Benjamin Kott commented on patch set 6 CR -1 04/25/24, 13:15

    missing stlyeguide demos
  5. core-ci voted on patch set 4 V +1 04/25/24, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56704

  6. core-ci voted on patch set 5 V +1 04/25/24, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56705

  7. core-ci voted on patch set 6 V +1 04/25/24, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56706

  8. Benjamin Kott uploaded patch set 7 CR -1 V +1 04/25/24, 13:56

  9. core-ci voted on patch set 7 V -1 04/25/24, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56708

  10. Benjamin Kott uploaded patch set 8 V -1 04/26/24, 05:46

  11. core-ci voted on patch set 8 V +1 04/26/24, 05:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56746

  12. Benjamin Kott uploaded patch set 9 V +1 04/26/24, 06:05

  13. core-ci voted on patch set 9 V +1 04/26/24, 06:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56747

  14. Benjamin Franzke commented on patch set 8 04/26/24, 06:14

    _root.scss:31

    I think this is not quite right. Light-and-dark ortdering is switched. Dark needs darker shadows, yes, but first always needs to be the lower value.

    _root.scss:35

    I think we need to differentiate offset-y for first and second shadow. One needs to be linear (to express elevation), while the other one should be rather static (to behave as key-shadow).

    _tree.scss:369

    ^^
  15. Benjamin Franzke uploaded patch set 10 V +1 04/26/24, 06:53

  16. Benjamin Franzke uploaded patch set 11 04/26/24, 06:58

  17. Benjamin Franzke commented on patch set 11 04/26/24, 06:58

    _root.scss:31 Reply

    Done

    _root.scss:35 Reply

    Done
  18. core-ci voted on patch set 10 V -1 04/26/24, 06:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56748

  19. Benjamin Franzke uploaded patch set 12 04/26/24, 07:03

  20. core-ci voted on patch set 11 V -1 04/26/24, 07:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56749

  21. core-ci voted on patch set 12 V +1 04/26/24, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56750

  22. Benjamin Franzke voted on patch set 12 CR +1 V +1 04/26/24, 07:09

  23. Andreas Kienast voted on patch set 12 CR +1 V +1 04/26/24, 07:18

  24. Benjamin Kott voted on patch set 12 CR +2 V +2 04/26/24, 07:18

  25. Benjamin Kott merged patch set 13 04/26/24, 07:18