Review main Merged

84021[TASK] Add missing label to file rename modal form

Willi Wehmeier CR +2 V +2 Easy +12 −3 updated 04/25/24, 14:06

Commit message

The modal form to rename a file needs a proper label
for the filename input field.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 78

  1. Willi Wehmeier uploaded patch set 1 04/25/24, 11:59

  2. core-ci voted on patch set 1 V +1 04/25/24, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56698

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 04/25/24, 12:05

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 04/25/24, 12:19

  5. Oli Bartsch commented on patch set 1 04/25/24, 12:58

    Unsure whether to backport this, introducing a new label which is not translated, yet.
  6. Andreas Kienast commented on patch set 1 04/25/24, 13:06

    Reply

    We already did this in the past, this should be fine. Also, this is arguably even a bugfix as it improves the accessibility a bit.
  7. Oli Bartsch commented on patch set 1 CR +2 V +2 04/25/24, 14:06

    Reply

    Acknowledged
  8. Oli Bartsch merged patch set 2 04/25/24, 14:06