Review main Merged

84034[BUGFIX] Respect option 'with site set' for ext:styleguide generator

Anja Leichsenring CR +2 V +2 Easy +2 −2 updated 07/31/24, 18:20

Commit message

With #103523 site sets for ext:styleguide were introduced and
the page tree generator received an option to create a frontend
demo section using the shipped set.

Now the click on this button will actually respect the user's wish
and create the site using the set and not create a sys_template
record.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1214

  1. Anja Leichsenring uploaded patch set 1 04/26/24, 07:36

  2. Benjamin Franzke commented on patch set 1 CR +1 V +1 04/26/24, 07:40

    Thanks!
  3. Simon Schaufelberger commented on patch set 1 04/26/24, 07:40

    users is plural but in this case it's the user's wish
  4. core-ci voted on patch set 1 V +1 04/26/24, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56753

  5. Benjamin Franzke updated the commit message in patch set 2 CR +1 V +1 04/26/24, 07:49

  6. Benjamin Franzke commented on patch set 2 CR +1 V +1 04/26/24, 07:50

    Reply

    ack (feel free to edit typo's directly). fixed.
  7. Mathias Brodala commented on patch set 2 04/26/24, 07:54

    BackendController.php:233

    Please use named arguments here to make clear from static reading what these to.
  8. core-ci voted on patch set 2 V +1 04/26/24, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56757

  9. Benjamin Franzke commented on patch set 2 04/26/24, 08:01

  10. Andreas Kienast voted on patch set 2 CR +1 V +1 04/26/24, 08:01

  11. Benjamin Franzke voted on patch set 2 CR +2 V +2 04/26/24, 08:01

  12. Benjamin Franzke merged patch set 3 04/26/24, 08:01

  13. Mathias Brodala commented on patch set 3 04/26/24, 08:10

    BackendController.php:233 Reply

    That's rather vague: > without clear further benefits I see a clear benefit: readable code without further lookup/research.
  14. Christian Kuhn commented on patch set 3 04/26/24, 08:57

    BackendController.php:233 Reply

    Not vague. "Avoid named arguments when calling TYPO3 Core API methods unless dealing with PCPP-based value objects." GeneratorFrontend is not a PCPP, so no use.