84034[BUGFIX] Respect option 'with site set' for ext:styleguide generator
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1214
-
Anja Leichsenring uploaded patch set 1 04/26/24, 07:36
-
Benjamin Franzke commented on patch set 1 CR +1 V +1 04/26/24, 07:40
Thanks! -
Simon Schaufelberger commented on patch set 1 04/26/24, 07:40
users is plural but in this case it's the user's wish -
core-ci voted on patch set 1 V +1 04/26/24, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56753
-
Benjamin Franzke updated the commit message in patch set 2
CR +1V +104/26/24, 07:49 -
Benjamin Franzke commented on patch set 2 CR +1 V +1 04/26/24, 07:50
Reply
ack (feel free to edit typo's directly). fixed. -
Mathias Brodala commented on patch set 2 04/26/24, 07:54
BackendController.php:233Please use named arguments here to make clear from static reading what these to. -
core-ci voted on patch set 2 V +1 04/26/24, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56757
-
Benjamin Franzke commented on patch set 2 04/26/24, 08:01
BackendController.php:233Reply -
Andreas Kienast voted on patch set 2 CR +1 V +1 04/26/24, 08:01
-
Benjamin Franzke voted on patch set 2 CR +2 V +2 04/26/24, 08:01
-
Benjamin Franzke merged patch set 3 04/26/24, 08:01
-
Mathias Brodala commented on patch set 3 04/26/24, 08:10
BackendController.php:233ReplyThat's rather vague: > without clear further benefits I see a clear benefit: readable code without further lookup/research. -
Christian Kuhn commented on patch set 3 04/26/24, 08:57
BackendController.php:233ReplyNot vague. "Avoid named arguments when calling TYPO3 Core API methods unless dealing with PCPP-based value objects." GeneratorFrontend is not a PCPP, so no use.