Review 12.4 Merged

84036[BUGFIX] Correctly resolve relative imports in page.tsconfig

Benjamin Franzke CR +2 V +2 Normal +87 −11 updated 05/27/24, 13:52

Commit message

Add a filename context to page.tsconfig include nodes
(autoloaded from extensions Configuration folder or from site sets)
in order to allow relative imports to be resolved.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 16

Review log 711

  1. Benjamin Franzke uploaded patch set 1 04/26/24, 09:06

  2. core-ci voted on patch set 1 V -1 04/26/24, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56763

  3. Benjamin Franzke uploaded patch set 2 V -1 04/26/24, 09:15

  4. core-ci voted on patch set 2 V +1 04/26/24, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56764

  5. Benjamin Franzke uploaded patch set 3 V +1 04/29/24, 06:57

  6. core-ci voted on patch set 3 V +1 04/29/24, 07:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56952

  7. Benjamin Franzke uploaded patch set 4 V +1 05/27/24, 12:18

  8. Benjamin Franzke marked it work in progress 05/27/24, 12:19

  9. core-ci voted on patch set 4 V +1 05/27/24, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58340

  10. Benjamin Franzke commented on patch set 4 CR +2 V +2 05/27/24, 13:51

    This change is ready for review.
  11. Benjamin Franzke merged patch set 5 05/27/24, 13:52