Review main Merged

84037[TASK] Use PAGEVIEW in EXT:styleguide site set

Oli Bartsch CR +2 V +2 Normal +54 −33 updated 04/30/24, 09:13

Commit message

The EXT:styleguide extension currently
provides two ways of frontend rendering.
The "old" way using a `sys_template`
record and the "new" way, using site sets.

To not only test the new site sets feature,
but also the new PAGEVIEW cObject is the
corresponding TypoScript now using the
PAGEVIEW for page rendering.

This one hand is the best practice and on
the other hand also allows to test both
ways: FLUIDTEMPLATE and PAGEVIEW in one
extension.

Required structural changes also showcase
what has to be done when migrating extensions
to site sets and PAGEVIEW.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Jörg Bösche +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1216

  1. Oli Bartsch uploaded patch set 1 04/26/24, 10:44

  2. Oli Bartsch uploaded patch set 2 04/26/24, 10:48

  3. core-ci voted on patch set 1 V -1 04/26/24, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56771

  4. core-ci voted on patch set 2 V -1 04/26/24, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56772

  5. Oli Bartsch uploaded patch set 3 V -1 04/26/24, 13:40

  6. core-ci voted on patch set 3 V +1 04/26/24, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56786

  7. Benni Mack voted on patch set 3 CR +1 V +1 04/29/24, 08:47

  8. Jörg Bösche voted on patch set 3 CR +1 04/30/24, 06:24

  9. Benjamin Franzke commented on patch set 3 CR -1 04/30/24, 06:31

    Default.html:19

    This shows differences in FLUIDTEMPLATE and PAGEVIEW. Let's provide different layouts for each variant.
  10. Benjamin Franzke uploaded patch set 4 CR +1 V +1 04/30/24, 07:07

  11. Benjamin Franzke commented on patch set 4 04/30/24, 07:07

    Default.html:19 Reply

    Done
  12. core-ci voted on patch set 4 V +1 04/30/24, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57000

  13. Benni Mack voted on patch set 4 CR +1 V +1 04/30/24, 08:53

  14. Jörg Bösche voted on patch set 4 CR +1 04/30/24, 09:04

  15. Benjamin Franzke voted on patch set 4 CR +2 V +2 04/30/24, 09:13

  16. Benjamin Franzke merged patch set 5 04/30/24, 09:13