84038[TASK] Add streamlined progress bar component
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Nedbal +1
- Georg Ringer +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Nedbal +1
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 33
- Build/Sources/Sass/typo3/_install.scss+1 −1
- Build/Sources/TypeScript/backend/element/progress-bar-element.tsnew+150 −0
- Build/Sources/TypeScript/backend/login-refresh.ts2+4 −14
- Build/Sources/TypeScript/backend/multi-step-wizard.ts+36 −73
- Build/Sources/TypeScript/backend/wizard.ts+16 −25
- Build/Sources/TypeScript/install/module/maintenance/language-packs.ts+5 −6
- Build/Sources/TypeScript/install/module/upgrade/extension-scanner.ts+18 −18
- Build/Sources/TypeScript/install/module/upgrade/upgrade-wizards.ts+7 −13
- Build/Sources/TypeScript/install/module/abstract-interactable-module.ts+7 −7
- Build/Sources/TypeScript/install/renderable/progress-bar.tsdeleted+0 −49
- Build/Sources/TypeScript/install/installer.ts+6 −15
- Build/Sources/TypeScript/install/router.ts+2 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/element/progress-bar-element.jsnew+96 −0
- typo3/sysext/backend/Resources/Public/JavaScript/login-refresh.js+4 −15
- typo3/sysext/backend/Resources/Public/JavaScript/multi-step-wizard.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/wizard.js+1 −1
- typo3/sysext/core/Resources/Private/Language/wizard.xlf+2 −2
- typo3/sysext/install/Resources/Private/Templates/Installer/MainLayout.html+1 −6
- typo3/sysext/install/Resources/Private/Templates/Upgrade/ExtensionScanner.html4+1 −5
Show 13 more files
- typo3/sysext/install/Resources/Private/Templates/Upgrade/UpgradeWizards.html+5 −4
- typo3/sysext/install/Resources/Public/JavaScript/module/maintenance/language-packs.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/extension-scanner.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/upgrade-wizards.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/abstract-interactable-module.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/renderable/progress-bar.jsdeleted+0 −19
- typo3/sysext/install/Resources/Public/JavaScript/installer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/router.js+1 −1
- typo3/sysext/scheduler/Resources/Private/Partials/TaskList.html+1 −3
- typo3/sysext/scheduler/Resources/Private/Templates/ListTasks.html+5 −4
- typo3/sysext/styleguide/Classes/Controller/BackendController.php+11 −0
- typo3/sysext/styleguide/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/ProgressIndicators.htmlnew+46 −0
Review log 2640
Show 815 earlier messages
-
Andreas Kienast uploaded patch set 1 04/26/24, 12:20
-
core-ci voted on patch set 1 V -1 04/26/24, 12:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56777
-
Andreas Kienast uploaded patch set 2
V -104/30/24, 11:54 -
core-ci voted on patch set 2 V +1 04/30/24, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57014
-
Andreas Kienast uploaded patch set 3
V +105/01/24, 15:09 -
core-ci voted on patch set 3 V +1 05/01/24, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57048
-
Andreas Kienast uploaded patch set 4
V +105/01/24, 15:19 -
core-ci voted on patch set 4 V +1 05/01/24, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57049
-
Andreas Kienast uploaded patch set 5
V +105/04/24, 16:50 -
core-ci voted on patch set 5 V +1 05/04/24, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57208
-
Andreas Kienast uploaded patch set 6
V +105/08/24, 09:02 -
core-ci voted on patch set 6 V +1 05/08/24, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57400
-
Andreas Kienast uploaded patch set 7
V +105/08/24, 09:12 -
core-ci voted on patch set 7 V +1 05/08/24, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57401
-
Andreas Kienast updated the commit message in patch set 8
V +105/08/24, 09:32
-
Andreas Kienast voted on patch set 8 CR -2 05/08/24, 09:32
-
core-ci voted on patch set 8 V +1 05/08/24, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57402
-
Andreas Kienast uploaded patch set 9
V +105/08/24, 11:37Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 9 V -1 05/08/24, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57407
-
Andreas Kienast uploaded patch set 10
V -105/08/24, 12:46Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 10 V +1 05/08/24, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57408
-
Andreas Kienast uploaded patch set 11
V +105/13/24, 15:15Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Andreas Kienast voted on patch set 11 CR 0 05/13/24, 15:15
-
core-ci voted on patch set 11 V +1 05/13/24, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57624
-
Andreas Kienast uploaded patch set 12
V +105/16/24, 06:33 -
core-ci voted on patch set 12 V +1 05/16/24, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57821
-
Andreas Kienast uploaded patch set 13
V +105/24/24, 08:44 -
core-ci voted on patch set 13 V +1 05/24/24, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58141
-
Andreas Nedbal voted on patch set 13 CR +1 V +1 05/24/24, 09:03
-
Benjamin Franzke commented on patch set 13 05/28/24, 13:53
login-refresh.ts:243As this module is imported by login-refresh.js directly, this should not be necessary, as login-refresh.js is always loaded in the top level document. (via `typo3/sysext/backend/Classes/Controller/BackendController.php::main()`) -
Andreas Kienast commented on patch set 13 V -1 05/28/24, 13:57
V-1 while bnf is reviewing -
Benjamin Franzke uploaded patch set 14
CR +1V +105/31/24, 08:01 -
Benjamin Franzke commented on patch set 14 05/31/24, 08:01
login-refresh.ts:243ReplyDoneExtensionScanner.html:72Can we use the new progress bar in here as well? This one has actually a bug currently (also in v12), the progress bar is rendered at the top, because there is no `position: relative` on the `.panel` container. -
core-ci voted on patch set 14 V +1 05/31/24, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58526
-
Andreas Kienast commented on patch set 14 05/31/24, 08:37
ExtensionScanner.html:72ReplyI'm not sure whether this is on purpose to fake the nprogress look. Let's check whether we can use the component as well. -
Andreas Kienast commented on patch set 14 06/10/24, 13:18
ExtensionScanner.html:72ReplyI think we should keep this for now. The progress calculation should we streamlined into one single bar at a later point. -
Andreas Nedbal voted on patch set 14 CR +1 V +1 06/10/24, 20:04
-
Georg Ringer voted on patch set 14 CR +1 V +1 06/10/24, 20:19
-
Benjamin Franzke commented on patch set 14 CR +2 V +2 06/11/24, 09:30
ExtensionScanner.html:72ReplyFine be my, though I'm sure this worked in v11 or so and broke with some bootstrap upgrade. -
Benjamin Franzke merged patch set 15 06/11/24, 09:30