Review main Merged

84038[TASK] Add streamlined progress bar component

Andreas Kienast CR +2 V +2 Hard +436 −290 updated 06/11/24, 09:30

Commit message

This commit introduces a new component to render progress bars in a
streamlined fashion, addressing common accessibility issues by
providing proper aria attributes.

The component supports a `max` value and a relative `value` attribute.
If `value` is omitted, the progress bar is rendered in an indeterminate
state.
If `value` is present, an optional `severity` attribute can get passed
to visually describe the state of the progress bar. Please note that
only successful, warning and error states are supported.
Additionally, an optional `label` can get passed, describing the
progress bar and its current state.

Important note: this component is rather experimental by now and may
change in a few details. Until further notice, this component is
strictly for internal use only.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 33

Show 13 more files

Review log 2640

Show 815 earlier messages
  1. Andreas Kienast uploaded patch set 1 04/26/24, 12:20

  2. core-ci voted on patch set 1 V -1 04/26/24, 12:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56777

  3. Andreas Kienast uploaded patch set 2 V -1 04/30/24, 11:54

  4. core-ci voted on patch set 2 V +1 04/30/24, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57014

  5. Andreas Kienast uploaded patch set 3 V +1 05/01/24, 15:09

  6. core-ci voted on patch set 3 V +1 05/01/24, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57048

  7. Andreas Kienast uploaded patch set 4 V +1 05/01/24, 15:19

  8. core-ci voted on patch set 4 V +1 05/01/24, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57049

  9. Andreas Kienast uploaded patch set 5 V +1 05/04/24, 16:50

  10. core-ci voted on patch set 5 V +1 05/04/24, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57208

  11. Andreas Kienast uploaded patch set 6 V +1 05/08/24, 09:02

  12. core-ci voted on patch set 6 V +1 05/08/24, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57400

  13. Andreas Kienast uploaded patch set 7 V +1 05/08/24, 09:12

  14. core-ci voted on patch set 7 V +1 05/08/24, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57401

  15. Andreas Kienast updated the commit message in patch set 8 V +1 05/08/24, 09:32

  1. Andreas Kienast voted on patch set 8 CR -2 05/08/24, 09:32

  2. core-ci voted on patch set 8 V +1 05/08/24, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57402

  3. Andreas Kienast uploaded patch set 9 V +1 05/08/24, 11:37

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  4. core-ci voted on patch set 9 V -1 05/08/24, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57407

  5. Andreas Kienast uploaded patch set 10 V -1 05/08/24, 12:46

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  6. core-ci voted on patch set 10 V +1 05/08/24, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57408

  7. Andreas Kienast uploaded patch set 11 V +1 05/13/24, 15:15

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  8. Andreas Kienast voted on patch set 11 CR 0 05/13/24, 15:15

  9. core-ci voted on patch set 11 V +1 05/13/24, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57624

  10. Andreas Kienast uploaded patch set 12 V +1 05/16/24, 06:33

  11. core-ci voted on patch set 12 V +1 05/16/24, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57821

  12. Andreas Kienast uploaded patch set 13 V +1 05/24/24, 08:44

  13. core-ci voted on patch set 13 V +1 05/24/24, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58141

  14. Andreas Nedbal voted on patch set 13 CR +1 V +1 05/24/24, 09:03

  15. Benjamin Franzke commented on patch set 13 05/28/24, 13:53

    login-refresh.ts:243

    As this module is imported by login-refresh.js directly, this should not be necessary, as login-refresh.js is always loaded in the top level document. (via `typo3/sysext/backend/Classes/Controller/BackendController.php::main()`)
  16. Andreas Kienast commented on patch set 13 V -1 05/28/24, 13:57

    V-1 while bnf is reviewing
  17. Benjamin Franzke uploaded patch set 14 CR +1 V +1 05/31/24, 08:01

  18. Benjamin Franzke commented on patch set 14 05/31/24, 08:01

    login-refresh.ts:243 Reply

    Done

    ExtensionScanner.html:72

    Can we use the new progress bar in here as well? This one has actually a bug currently (also in v12), the progress bar is rendered at the top, because there is no `position: relative` on the `.panel` container.
  19. core-ci voted on patch set 14 V +1 05/31/24, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58526

  20. Andreas Kienast commented on patch set 14 05/31/24, 08:37

    ExtensionScanner.html:72 Reply

    I'm not sure whether this is on purpose to fake the nprogress look. Let's check whether we can use the component as well.
  21. Andreas Kienast commented on patch set 14 06/10/24, 13:18

    ExtensionScanner.html:72 Reply

    I think we should keep this for now. The progress calculation should we streamlined into one single bar at a later point.
  22. Andreas Nedbal voted on patch set 14 CR +1 V +1 06/10/24, 20:04

  23. Georg Ringer voted on patch set 14 CR +1 V +1 06/10/24, 20:19

  24. Benjamin Franzke commented on patch set 14 CR +2 V +2 06/11/24, 09:30

    ExtensionScanner.html:72 Reply

    Fine be my, though I'm sure this worked in v11 or so and broke with some bootstrap upgrade.
  25. Benjamin Franzke merged patch set 15 06/11/24, 09:30