Review main Merged

84044[BUGFIX] Remove wrong title attribute on icon in "Localization overview"

Jasmina Ließmann CR +2 V +2 Easy +4 −1 updated 04/27/24, 11:05

Commit message

In the "Localization overview" view, an incorrect title was displayed
when hovering over a page icon. This was caused by both an incorrect
and duplicate title attribute. This patch fixes this behavior.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Jasmina Ließmann uploaded patch set 1 04/26/24, 21:39

  2. core-ci voted on patch set 1 V +1 04/26/24, 21:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56811

  3. Jasmina Ließmann updated the commit message in patch set 2 V +1 04/26/24, 21:45

  4. core-ci voted on patch set 2 V +1 04/26/24, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56812

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 04/26/24, 22:27

  6. Christian Kuhn commented on patch set 2 04/26/24, 22:27

    good catch.
  7. Garvin Hicking voted on patch set 2 CR +1 V +1 04/27/24, 08:00

  8. Jasmina Ließmann voted on patch set 2 CR +2 V +2 04/27/24, 11:04

  9. Jasmina Ließmann merged patch set 3 04/27/24, 11:05