84045[TASK] Extract 'free mode' tests to own scenario
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- André Buchmann +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
- André Buchmann +1
- core-ci +1 CI
Issues 2
Files 31
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/DataSet/ImportFreeModeElements.csvdeleted+0 −13
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/ActionTest.php+0 −25
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesDiscard/ActionTest.php+0 −24
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesModify/ActionTest.php+0 −31
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublish/ActionTest.php+0 −36
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublishAll/ActionTest.php+0 −31
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/AbstractActionTestCase.php+0 −37
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/AbstractActionWorkspacesTestCase.php+0 −26
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/DataSet/ImportDefault.csvnew+34 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/DataSet/ImportDefaultWorkspaces.csvnew+41 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/Modify/DataSet/copyPage.csvrenamed+0 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/Modify/DataSet/localizeContentAfterMovedContent.csvrenamed+0 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/Modify/ActionTest.phpnew+59 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/WorkspacesDiscard/DataSet/copyPage.csvrenamed+0 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/WorkspacesDiscard/DataSet/localizeContentAfterMovedContent.csvrenamed+0 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/WorkspacesDiscard/DataSet/localizeContentAfterMovedInLiveContent.csvrenamed+0 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/WorkspacesDiscard/ActionTest.phpnew+55 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/WorkspacesModify/DataSet/copyPage.csvrenamed+0 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/WorkspacesModify/DataSet/localizeContentAfterMovedContent.csvrenamed+0 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/WorkspacesModify/DataSet/localizeContentAfterMovedInLiveContent.csvrenamed+0 −0
Show 11 more files
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/WorkspacesModify/ActionTest.phpnew+66 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/WorkspacesPublish/DataSet/copyPage.csvrenamed+0 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/WorkspacesPublish/DataSet/localizeContentAfterMovedContent.csvrenamed+0 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/WorkspacesPublish/DataSet/localizeContentAfterMovedInLiveContent.csvrenamed+0 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/WorkspacesPublish/ActionTest.phpnew+70 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/WorkspacesPublishAll/DataSet/copyPage.csvrenamed+0 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/WorkspacesPublishAll/DataSet/localizeContentAfterMovedContent.csvrenamed+0 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/WorkspacesPublishAll/DataSet/localizeContentAfterMovedInLiveContent.csvrenamed+0 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/WorkspacesPublishAll/ActionTest.phpnew+65 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/AbstractActionTestCase.phpnew+90 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/AbstractActionWorkspacesTestCase.phpnew+49 −0
Review log 810
-
Christian Kuhn uploaded patch set 1 04/27/24, 00:53
-
core-ci voted on patch set 1 V +1 04/27/24, 00:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56817
-
André Buchmann uploaded patch set 2
V +104/27/24, 06:42 -
André Buchmann commented on patch set 2 CR +1 V +1 04/27/24, 06:45
Clean extraction. Changed hard coded Ids in AbstractActionTestCase back to constants in Patchset 2 -
core-ci voted on patch set 2 V +1 04/27/24, 06:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56840
-
Oliver Klee voted on patch set 2 V +1 04/27/24, 08:21
-
Anja Leichsenring voted on patch set 2 CR +1 V +1 04/27/24, 09:25
-
Anja Leichsenring voted on patch set 2 CR +2 V +2 04/27/24, 09:25
-
Anja Leichsenring merged patch set 3 04/27/24, 09:25
-
Christian Kuhn commented on patch set 2 04/27/24, 09:29
Reply
I'm always fighting with myselfs if all those constants are actually useful: The DataScenarios have this relatively complex class dependency chain (a global abstract for DataScenarios, an abstract for "all" cases of a scenario, an abstract for the workspace variants. The constants then add another orthogonal dimension when looking at test, import and result csv in parallel. I found this hard to grasp when working with the tests since i constantly forget the constant values, and it would be easier to grasp to just hardcode the id's. This would also allow to have more tests with their distinct uid-set in import files - I followed this approach in RootlineUtilityTest with great success. As such, I'm tempted to remove those uid constants over time, but it's not urgent in any way and we can keep the current construct for now.