84048[TASK] Revise toolbar for CKEditor "full" configuration preset
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Chris Müller +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Chris Müller +1
- core-ci +1 CI
Issues 1
Files 1
Review log 89
-
Torben Hansen uploaded patch set 1 04/27/24, 12:53
-
core-ci voted on patch set 1 V +1 04/27/24, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56852
-
Georg Ringer commented on patch set 1 04/29/24, 11:35
i am not sure about the v12 changes as editors might be used to that? -
Torben Hansen commented on patch set 1 04/29/24, 12:48
Reply
So should we just fix the wrong things first in v12+v13 (`clipboard` and `find`) and add new buttons to v13 only? -
Georg Ringer commented on patch set 1 04/29/24, 21:26
TBH I am unsure but once we agreed that UI & rendering must not change in released versions. I am fine with both -
Benjamin Franzke commented on patch set 1 CR +1 V +1 04/30/24, 04:28
Reply
Corrections/Improvements are allowed to v12, even if they change things. Every Button/Label change would otherwise be disallowed for v12. We actually already changed the full-preset multiple times in 12.x as: * We had the readd missing plugins after LTS release * We basically see full-preset as a demo-palette, as it has always been overloaded (I still think it's good to apply a better structure, so thanks Torben!) -
Chris Müller voted on patch set 1 CR +1 V +1 05/02/24, 17:33
-
Benjamin Franzke voted on patch set 1 CR +2 V +2 05/03/24, 06:28
-
Benjamin Franzke merged patch set 2 05/03/24, 06:35