Review main Merged

84048[TASK] Revise toolbar for CKEditor "full" configuration preset

Torben Hansen CR +2 V +2 Easy +6 −4 updated 05/03/24, 06:35

Commit message

With this change, the following changes have been applied to the
toolbar of the CKEditor "full" configuration preset:

* Remove superfluous `clipboard` toolbar item, since CKEditor 5 does
  not provide a UI for the clipboard plugin.

* Rename wrong `find` toolbar item to `findAndReplace`.

* Added `TableProperties` and `TableCellProperties` toolbar items.

* Move the `findAndReplace` toolbar item before the `link` toolbar
  item, because we also have this order in the `default` preset.

* Move the `selectAll` toolbar item to a dedicated group

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Chris Müller +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Chris Müller +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Torben Hansen uploaded patch set 1 04/27/24, 12:53

  2. core-ci voted on patch set 1 V +1 04/27/24, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56852

  3. Georg Ringer commented on patch set 1 04/29/24, 11:35

    i am not sure about the v12 changes as editors might be used to that?
  4. Torben Hansen commented on patch set 1 04/29/24, 12:48

    Reply

    So should we just fix the wrong things first in v12+v13 (`clipboard` and `find`) and add new buttons to v13 only?
  5. Georg Ringer commented on patch set 1 04/29/24, 21:26

    TBH I am unsure but once we agreed that UI & rendering must not change in released versions. I am fine with both
  6. Benjamin Franzke commented on patch set 1 CR +1 V +1 04/30/24, 04:28

    Reply

    Corrections/Improvements are allowed to v12, even if they change things. Every Button/Label change would otherwise be disallowed for v12. We actually already changed the full-preset multiple times in 12.x as: * We had the readd missing plugins after LTS release * We basically see full-preset as a demo-palette, as it has always been overloaded (I still think it's good to apply a better structure, so thanks Torben!)
  7. Chris Müller voted on patch set 1 CR +1 V +1 05/02/24, 17:33

  8. Benjamin Franzke voted on patch set 1 CR +2 V +2 05/03/24, 06:28

  9. Benjamin Franzke merged patch set 2 05/03/24, 06:35