Review main Merged

84049[TASK] Improve refindex import check in DataScenarios test

Christian Kuhn CR +2 V +2 Hard +300 −120 updated 04/27/24, 14:20

Commit message

All DataScenarios tests import a single CSV as DB base
state to operate on. Single action tests verify in tearDown()
the reference index is clean (an update changes nothing).
This means the imported CSV must come with a clean refindex
in the first place. The verifyCleanReferenceIndex() tests
check this explicitely.

The patch changes verifyCleanReferenceIndex() tests to actually
run the reference index updater in non-test mode, to then assert
the DB state with the initially imported CSV again: If the
reference index updater changed something, the test fails.

This change simplifies management of the refindex part of
the import CSV, since the assert now output all broken
rows in detail. This should make it more easy to change details
of the imported base set.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • André Buchmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • André Buchmann +1
    • core-ci +1 CI

Issues 3

Files 60

Show 40 more files

Review log 45

  1. Christian Kuhn uploaded patch set 1 04/27/24, 13:31

  2. core-ci voted on patch set 1 V +1 04/27/24, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56855

  3. André Buchmann voted on patch set 1 CR +1 V +1 04/27/24, 14:02

  4. Christian Kuhn commented on patch set 1 CR +2 V +2 04/27/24, 14:20

    I hope it's ok taking the freedom to merge here with a missing core-merger vote: This is a 'test only' patch, and yet another pre-patch of a bigger change.
  5. Christian Kuhn merged patch set 2 04/27/24, 14:20