Review main Merged

84051[TASK] Avoid sorting issue in RootlineUtilityTest

Christian Kuhn CR +2 V +2 Normal +90 −90 updated 04/27/24, 15:37

Commit message

A missing additional orderBy() in RelationHandler
leads to the situation that different DB vendor
may return relations in different order, *if*
the MM table "local sorting" value isn't unique.

Patch for issue #103735 added an according `@todo`
for this scenario in RelationHandler already.

The import CSV test set of RootlineUtilityTest
from issue #103680 is a victim here since the
category MM rows have no proper unique sorting
on the local side.

The patch fixes the import CSV to have proper
sorting values.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 04/27/24, 15:16

  2. core-ci voted on patch set 1 V +1 04/27/24, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56859

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 04/27/24, 15:28

  4. Andreas Nedbal voted on patch set 1 CR +1 V +1 04/27/24, 15:36

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 04/27/24, 15:37

  6. Christian Kuhn merged patch set 2 04/27/24, 15:37