Review main Merged

84072[TASK] Resolve `@todo` in AbstractFormFieldViewHelper

Torben Hansen CR +2 V +2 Easy +5 −5 updated 06/17/24, 22:31

Commit message

This change resolves the `@todo` in `AbstractFormFieldViewHelper`
by using the suggested method from `PersistenceManager`, which
has been implemented with #42505.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Torben Hansen uploaded patch set 1 04/27/24, 16:57

  2. core-ci voted on patch set 1 V +1 04/27/24, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56861

  3. Oliver Klee updated the commit message in patch set 2 V +1 04/27/24, 19:02

  4. core-ci voted on patch set 2 V +1 04/27/24, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56864

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 04/28/24, 18:10

  6. Oliver Klee commented on patch set 2 04/29/24, 08:59

    How can I test this?
  7. Torben Hansen commented on patch set 2 04/29/24, 09:29

    Reply

    You have a Fluid form field, which has a `name` property and a `value`. The value must be a persisted object. Example: `<f:form.textfield name="foo" value="{bar}" />` Fluid will render: `<input type="text" name="tx_extension_plugin[foo][__identity]" value="123">`, where `123` is the UID of the persisted object. The same applies to ViewHelpers using the `property` attribute and where a dedicated object is given as `value`. To be honest, I did not understand the usecase for this feature and if it is really used somewhere in extensions.
  8. Georg Ringer voted on patch set 2 CR +1 V +1 06/10/24, 22:04

  9. Benni Mack commented on patch set 2 CR +2 V +2 06/17/24, 22:31

    Reply

    Done
  10. Benni Mack merged patch set 3 06/17/24, 22:31