Review main Merged

84074[BUGFIX] Avoid undefined array key warnings in SuggestWizardController

Torben Hansen CR +2 V +2 Normal +87 −2 updated 04/28/24, 18:18

Commit message

When an editor uses the suggest wizard, undefined array key warnings
can occur, when certain array keys have not been defined.

This change adds fallbacks for undefined array keys using the
null coalescing operator. Additionally, the function
`currentBackendUserMayAccessTable` is now covered with unit tests.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Torben Hansen uploaded patch set 1 04/28/24, 05:08

  2. core-ci voted on patch set 1 V +1 04/28/24, 05:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56897

  3. Torben Hansen updated the commit message in patch set 2 V +1 04/28/24, 05:17

  4. core-ci voted on patch set 2 V +1 04/28/24, 05:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56899

  5. Torben Hansen updated the commit message in patch set 3 V +1 04/28/24, 05:29

  6. core-ci voted on patch set 3 V +1 04/28/24, 05:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56900

  7. Oliver Klee commented on patch set 3 CR +1 04/28/24, 07:53

    11.5 (with PHP 8.x) is not affected?
  8. Oliver Klee voted on patch set 3 V +1 04/28/24, 07:53

  9. Torben Hansen commented on patch set 3 04/28/24, 08:18

    Reply

    Yes it is, but I doubt this change would make it into v11.5, because v11.5 is in priority bugfix mode only and the warning is not shown in production context,
  10. Stefan Bürk voted on patch set 3 CR +2 V +2 04/28/24, 18:10

  11. Stefan Bürk merged patch set 4 04/28/24, 18:18