Review main Merged

84078[TASK] Add description to allowed_languages field

Marcin Sągol CR +2 V +2 Easy +5 −0 updated 06/05/24, 14:06

Commit message

It might not be clear to users how the allowed_languages field works
by default when setting permissions for a backend user or group.

If no languages are selected from the allowed_languages list,
all languages will be available for the given user or group.

To make this clearer, a description has been added to explain it
straightforwardly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Guido Schmechel +1
    • Garvin Hicking +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Guido Schmechel +1
    • Garvin Hicking +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1820

  1. Marcin Sągol uploaded patch set 1 04/29/24, 07:01

  2. core-ci voted on patch set 1 V +1 04/29/24, 07:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56953

  3. Christian Wolff voted on patch set 1 CR +1 04/29/24, 07:21

  4. Oliver Klee voted on patch set 1 CR +1 04/29/24, 07:38

  5. Oli Bartsch commented on patch set 1 04/29/24, 07:52

    I wonder if we should also add a description to the "userMods" field, which behaves exactly the opposite.
  6. Marcin Sągol commented on patch set 1 04/29/24, 08:02

    Reply

    I can propose such description, maybe with a separate patch where i also will move 3 fields to a new tab `Modules permissions`.
  7. Georg Ringer voted on patch set 1 CR +1 V +1 04/30/24, 12:14

  8. Riccardo De Contardi voted on patch set 1 V +1 05/01/24, 14:49

  9. Guido Schmechel voted on patch set 1 CR +1 V +1 05/04/24, 18:19

  10. Stefan Bürk commented on patch set 1 05/11/24, 18:03

    locallang_tca.xlf:34

    Should this not be ``` If no language is selected, all languges will be available by default. ``` ?
  11. Marcin Sągol uploaded patch set 2 CR +1 V +1 06/03/24, 08:41

  12. Marcin Sągol commented on patch set 2 06/03/24, 08:42

    locallang_tca.xlf:34 Reply

    Done
  13. Marcin Sągol commented on patch set 2 06/03/24, 08:44

    Reply

    Done
  14. core-ci voted on patch set 2 V +1 06/03/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58612

  15. Torben Hansen voted on patch set 2 CR +1 V +1 06/03/24, 09:07

  16. Thomas Hohn voted on patch set 2 CR +1 06/03/24, 09:17

  17. Guido Schmechel voted on patch set 2 CR +1 V +1 06/05/24, 10:17

  18. Garvin Hicking voted on patch set 2 CR +1 V +1 06/05/24, 10:33

  19. Christian Kuhn voted on patch set 2 CR +2 V +2 06/05/24, 14:06

  20. Christian Kuhn merged patch set 3 06/05/24, 14:06