Review main Merged

84079[TASK] Make cropper presets usable with keyboard

Willi Wehmeier CR +2 V +2 Easy +34 −8 updated 06/10/24, 18:17

Commit message

The aspect ratio buttons in the image cropping tool
have a visible focus state now to make them usable
when navigating with the keyboard tab key.

Additionally the button can now be pressed with
the space and return key.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • Michael Telgkamp +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1014

  1. Willi Wehmeier uploaded patch set 1 04/29/24, 08:22

  2. core-ci voted on patch set 1 V +1 04/29/24, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56956

  3. Andreas Kienast commented on patch set 1 CR -1 05/03/24, 08:39

    on it
  4. Andreas Kienast uploaded patch set 2 CR -1 V +1 05/03/24, 08:47

  5. core-ci voted on patch set 2 V +1 05/03/24, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57166

  6. Andreas Kienast voted on patch set 2 CR +1 V +1 05/03/24, 13:58

  7. Andreas Kienast rebased onto patch set 3 CR +1 V +1 05/06/24, 05:28

  8. core-ci voted on patch set 3 V +1 05/06/24, 05:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57260

  9. Andreas Kienast rebased onto patch set 4 V +1 05/13/24, 06:11

  10. core-ci voted on patch set 4 V +1 05/13/24, 06:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57574

  11. Andreas Kienast voted on patch set 4 CR +1 V +1 05/17/24, 06:05

  12. Michael Telgkamp commented on patch set 4 CR +1 V +1 06/10/24, 12:53

    Thank you for the patch. The focus highlight will need to be taken into account in another patch. For the future it will also be required to enable keyboard users to change the crop. This will be another ticket.
  13. Georg Ringer voted on patch set 4 CR +2 V +2 06/10/24, 18:17

  14. Georg Ringer merged patch set 5 06/10/24, 18:17