84081[BUGFIX] Remove h4 from infobox to avoid breaking document hierarchy
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 18
- Build/Sources/Sass/component/_callout.scss+3 −2
- Build/Sources/TypeScript/install/renderable/info-box.ts+1 −1
- Build/Sources/TypeScript/install/router.ts+1 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/PasswordElement.php+1 −1
- typo3/sysext/backend/Resources/Private/Templates/Login/ForgetPasswordForm.html+3 −4
- typo3/sysext/backend/Resources/Private/Templates/Login/ResetPasswordForm.html+5 −12
- typo3/sysext/backend/Resources/Private/Templates/Security/CspModule.html+20 −40
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/core/Classes/Error/DebugExceptionHandler.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/MaintenanceCest.php+1 −1
- typo3/sysext/filelist/Resources/Private/Templates/File/UploadFile.html+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Be/InfoboxViewHelper.php+1 −1
- typo3/sysext/impexp/Resources/Private/Templates/Export.html+2 −2
- typo3/sysext/impexp/Resources/Private/Templates/Import.html+2 −2
- typo3/sysext/install/Resources/Private/Partials/Generic/ConfigurationNotWritable.html+4 −6
- typo3/sysext/install/Resources/Public/JavaScript/renderable/info-box.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/router.js+1 −1
Review log 1418
-
Frank Nägler uploaded patch set 1 04/29/24, 11:07
-
core-ci voted on patch set 1 V +1 04/29/24, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56960
-
Benjamin Kott voted on patch set 1 CR +1 V +1 04/29/24, 11:13
-
Benjamin Franzke commented on patch set 1 CR -1 04/29/24, 12:10
Build/Sources/Sass/component/_callout.scss still documents to use `h4` and ´h4 class="callout-tile"` and `div class="callout-title"` produce different rendering result, as line-height is different (h4 has `1.2` overwrite). @benjamin.kott@outlook.com opionion, should we set an explicit callout-title? Also: What about other usages? * typo3/sysext/core/Classes/Error/DebugExceptionHandler.php * typo3/sysext/backend/Resources/Private/Templates/Login/ResetPasswordForm.html * typo3/sysext/backend/Classes/Form/Element/PasswordElement.php * typo3/sysext/backend/Classes/Controller/EditDocumentController.php * Build/Sources/TypeScript/install/router.ts * Build/Sources/TypeScript/install/renderable/info-box.ts -
Frank Nägler commented on patch set 1 04/29/24, 12:23
Reply
for sure, we have other places that don't use the view helper ;) I will check that. Thanks for pointing that out. I also will remove the CSS part. -
Benjamin Franzke commented on patch set 1 04/29/24, 12:24
Reply
fixed formatting: Problem 1: Build/Sources/Sass/component/_callout.scss still documents to use h4. `h4 class="callout-tile"` and `div class="callout-title"` produce different rendering results, as `line-height` is different (`h4` has a `line-height: 1.2` overwrite). @benjamin.kott@outlook.com to you have an opinion, should we set an explicit `line-height` on `.callout-title`? -
Frank Nägler commented on patch set 1 04/29/24, 12:36
Reply
Benji said: the different layout is okay -
Frank Nägler uploaded patch set 2
CR +1V +104/29/24, 14:37 -
core-ci voted on patch set 2 V -1 04/29/24, 14:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56968
-
core-ci commented on patch set 2 04/29/24, 18:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56968
-
Benjamin Franzke uploaded patch set 3
V -104/29/24, 18:37 -
core-ci voted on patch set 3 V +1 04/29/24, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56974
-
Georg Ringer commented on patch set 3 CR -1 04/29/24, 20:46
officially we can't change the fluid VH in 12.4 as this changes the FE behavior and we commited to not do that. I am fine if we do so but previously this was not allowed -
Benjamin Franzke commented on patch set 3 04/30/24, 04:19
Reply
This is a viewhelper namespaced for BE context (`f:be.`). This is allowed. -
Georg Ringer voted on patch set 3 CR +1 V +1 04/30/24, 05:31
-
Benjamin Kott voted on patch set 3 CR +1 V +1 04/30/24, 07:27
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 04/30/24, 08:48
-
Benjamin Franzke merged patch set 4 04/30/24, 08:49