Review main Merged

84081[BUGFIX] Remove h4 from infobox to avoid breaking document hierarchy

Frank Nägler CR +2 V +2 Normal +51 −80 updated 04/30/24, 08:49

Commit message

This patch adjusts the infobox/callout element by removing the
h4 tag to prevent incorrect ordering in the content structure,
allowing for better flexibility based on different use cases.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 1418

  1. Frank Nägler uploaded patch set 1 04/29/24, 11:07

  2. core-ci voted on patch set 1 V +1 04/29/24, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56960

  3. Benjamin Kott voted on patch set 1 CR +1 V +1 04/29/24, 11:13

  4. Benjamin Franzke commented on patch set 1 CR -1 04/29/24, 12:10

    Build/Sources/Sass/component/_callout.scss still documents to use `h4` and ´h4 class="callout-tile"` and `div class="callout-title"` produce different rendering result, as line-height is different (h4 has `1.2` overwrite). @benjamin.kott@outlook.com opionion, should we set an explicit callout-title? Also: What about other usages? * typo3/sysext/core/Classes/Error/DebugExceptionHandler.php * typo3/sysext/backend/Resources/Private/Templates/Login/ResetPasswordForm.html * typo3/sysext/backend/Classes/Form/Element/PasswordElement.php * typo3/sysext/backend/Classes/Controller/EditDocumentController.php * Build/Sources/TypeScript/install/router.ts * Build/Sources/TypeScript/install/renderable/info-box.ts
  5. Frank Nägler commented on patch set 1 04/29/24, 12:23

    Reply

    for sure, we have other places that don't use the view helper ;) I will check that. Thanks for pointing that out. I also will remove the CSS part.
  6. Benjamin Franzke commented on patch set 1 04/29/24, 12:24

    Reply

    fixed formatting: Problem 1: Build/Sources/Sass/component/_callout.scss still documents to use h4. `h4 class="callout-tile"` and `div class="callout-title"` produce different rendering results, as `line-height` is different (`h4` has a `line-height: 1.2` overwrite). @benjamin.kott@outlook.com to you have an opinion, should we set an explicit `line-height` on `.callout-title`?
  7. Frank Nägler commented on patch set 1 04/29/24, 12:36

    Reply

    Benji said: the different layout is okay
  8. Frank Nägler uploaded patch set 2 CR +1 V +1 04/29/24, 14:37

  9. core-ci voted on patch set 2 V -1 04/29/24, 14:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56968

  10. core-ci commented on patch set 2 04/29/24, 18:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56968

  11. Benjamin Franzke uploaded patch set 3 V -1 04/29/24, 18:37

  12. core-ci voted on patch set 3 V +1 04/29/24, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56974

  13. Georg Ringer commented on patch set 3 CR -1 04/29/24, 20:46

    officially we can't change the fluid VH in 12.4 as this changes the FE behavior and we commited to not do that. I am fine if we do so but previously this was not allowed
  14. Benjamin Franzke commented on patch set 3 04/30/24, 04:19

    Reply

    This is a viewhelper namespaced for BE context (`f:be.`). This is allowed.
  15. Georg Ringer voted on patch set 3 CR +1 V +1 04/30/24, 05:31

  16. Benjamin Kott voted on patch set 3 CR +1 V +1 04/30/24, 07:27

  17. Benjamin Franzke voted on patch set 3 CR +2 V +2 04/30/24, 08:48

  18. Benjamin Franzke merged patch set 4 04/30/24, 08:49