84082[BUGFIX] Remove h4 from alerts to avoid breaking document hierarchy
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/Sass/component/_alert.scss+1 −0
- Build/Sources/TypeScript/backend/notification.ts+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/notification.js+1 −1
- typo3/sysext/core/Classes/Messaging/Renderer/BootstrapRenderer.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/MaintenanceCest.php+3 −3
- typo3/sysext/core/Tests/Unit/Messaging/Renderer/BootstrapRendererTest.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/FlashMessagesViewHelper.php+1 −1
Review log 1115
-
Frank Nägler uploaded patch set 1 04/29/24, 11:12
-
Benjamin Kott voted on patch set 1 CR +1 V +1 04/29/24, 11:14
-
core-ci voted on patch set 1 V -1 04/29/24, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56961
-
Frank Nägler uploaded patch set 2
CR +1V +104/29/24, 14:39 -
core-ci voted on patch set 2 V +1 04/29/24, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56969
-
Benjamin Franzke uploaded patch set 3
V +104/29/24, 18:04 -
core-ci voted on patch set 3 V -1 04/29/24, 18:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56973
-
Benjamin Franzke uploaded patch set 4
CR +1V +104/29/24, 18:39 -
core-ci voted on patch set 4 V +1 04/29/24, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56975
-
Georg Ringer commented on patch set 4 CR -1 04/29/24, 20:44
officially we can't change the fluid VH in 12.4 as this changes the FE behavior and we commited to not do that. I am fine if we do so but previously this was not allowed -
Benjamin Franzke commented on patch set 4 04/30/24, 04:22
Reply
We only change the example here. The frontend implementation (`ListRenderer`) is not changed, only the one used in the backend context only (`BootstrapRenderer`), see: https://github.com/TYPO3/typo3/blob/1d86d5b4f41ba10ef1fc9cc56f2d2899480e17d9/typo3/sysext/core/Classes/Messaging/FlashMessageRendererResolver.php#L38-L39 Please rethink that vote. -
Georg Ringer voted on patch set 4 CR +1 V +1 04/30/24, 05:30
-
Benjamin Kott voted on patch set 4 CR +1 V +1 04/30/24, 07:28
-
Benjamin Franzke voted on patch set 4 CR +2 V +2 04/30/24, 08:48
-
Benjamin Franzke merged patch set 5 04/30/24, 08:49