Review main Merged

84082[BUGFIX] Remove h4 from alerts to avoid breaking document hierarchy

Frank Nägler CR +2 V +2 Easy +11 −10 updated 04/30/24, 08:49

Commit message

This patch adjusts the flash message and notifications elements by
removing the h4 tag to prevent incorrect header flow throughout the
content structure, allowing for better flexibility based on different
use cases.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1115

  1. Frank Nägler uploaded patch set 1 04/29/24, 11:12

  2. Benjamin Kott voted on patch set 1 CR +1 V +1 04/29/24, 11:14

  3. core-ci voted on patch set 1 V -1 04/29/24, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56961

  4. Frank Nägler uploaded patch set 2 CR +1 V +1 04/29/24, 14:39

  5. core-ci voted on patch set 2 V +1 04/29/24, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56969

  6. Benjamin Franzke uploaded patch set 3 V +1 04/29/24, 18:04

  7. core-ci voted on patch set 3 V -1 04/29/24, 18:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56973

  8. Benjamin Franzke uploaded patch set 4 CR +1 V +1 04/29/24, 18:39

  9. core-ci voted on patch set 4 V +1 04/29/24, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56975

  10. Georg Ringer commented on patch set 4 CR -1 04/29/24, 20:44

    officially we can't change the fluid VH in 12.4 as this changes the FE behavior and we commited to not do that. I am fine if we do so but previously this was not allowed
  11. Benjamin Franzke commented on patch set 4 04/30/24, 04:22

    Reply

    We only change the example here. The frontend implementation (`ListRenderer`) is not changed, only the one used in the backend context only (`BootstrapRenderer`), see: https://github.com/TYPO3/typo3/blob/1d86d5b4f41ba10ef1fc9cc56f2d2899480e17d9/typo3/sysext/core/Classes/Messaging/FlashMessageRendererResolver.php#L38-L39 Please rethink that vote.
  12. Georg Ringer voted on patch set 4 CR +1 V +1 04/30/24, 05:30

  13. Benjamin Kott voted on patch set 4 CR +1 V +1 04/30/24, 07:28

  14. Benjamin Franzke voted on patch set 4 CR +2 V +2 04/30/24, 08:48

  15. Benjamin Franzke merged patch set 5 04/30/24, 08:49