84083[BUGFIX] Cleanup markup in Linkvalidator modul
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1114
-
Frank Nägler uploaded patch set 1 04/29/24, 11:21
-
core-ci voted on patch set 1 V +1 04/29/24, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56962
-
Benjamin Kott voted on patch set 1 CR +1 V +1 04/29/24, 11:51
-
Benjamin Franzke commented on patch set 1 04/30/24, 06:07
-
Frank Nägler commented on patch set 1 04/30/24, 06:24
CheckOptions.html:11ReplyIn general yes, this table is IMHO the wrong element for the purpose. I have not changed this to td to keep the same behavior and look & feel. -
Benjamin Franzke uploaded patch set 2
CR +1V +104/30/24, 07:19 -
Benjamin Franzke commented on patch set 2 04/30/24, 07:19
CheckOptions.html:11ReplyI agree that we shouldn't change look & feel right now (this UI needs a general makeover), but as I'm sure that `<th>` is wrong, I've now changed to `<th>` + `<td>`, and also applied that to the following lines (which are key-values as well). -
Benjamin Kott voted on patch set 2 CR +1 V +1 04/30/24, 07:24
-
core-ci voted on patch set 2 V +1 04/30/24, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57001
-
Benjamin Franzke uploaded patch set 3
CR +1V +104/30/24, 07:26 -
Benjamin Kott voted on patch set 3 CR +1 V +1 04/30/24, 07:26
-
core-ci voted on patch set 3 V +1 04/30/24, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57002
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 04/30/24, 07:31
-
Benjamin Franzke merged patch set 4 04/30/24, 07:41
CheckOptions.html:11