Review main Merged

84083[BUGFIX] Cleanup markup in Linkvalidator modul

Frank Nägler CR +2 V +2 Easy +7 −10 updated 04/30/24, 07:41

Commit message

This patch enhances the accessibility of the link validator
module by ensuring proper relationships between table headers
and content cells.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Frank Nägler uploaded patch set 1 04/29/24, 11:21

  2. core-ci voted on patch set 1 V +1 04/29/24, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56962

  3. Benjamin Kott voted on patch set 1 CR +1 V +1 04/29/24, 11:51

  4. Benjamin Franzke commented on patch set 1 04/30/24, 06:07

    CheckOptions.html:11

    I'm not sure about this. The badge is a `<th>` itself, shouldn't this be a `<td>` if it is intended to be labeled via `headers` attribute? See also https://stackoverflow.com/a/76980288/4223467
  5. Frank Nägler commented on patch set 1 04/30/24, 06:24

    CheckOptions.html:11 Reply

    In general yes, this table is IMHO the wrong element for the purpose. I have not changed this to td to keep the same behavior and look & feel.
  6. Benjamin Franzke uploaded patch set 2 CR +1 V +1 04/30/24, 07:19

  7. Benjamin Franzke commented on patch set 2 04/30/24, 07:19

    CheckOptions.html:11 Reply

    I agree that we shouldn't change look & feel right now (this UI needs a general makeover), but as I'm sure that `<th>` is wrong, I've now changed to `<th>` + `<td>`, and also applied that to the following lines (which are key-values as well).
  8. Benjamin Kott voted on patch set 2 CR +1 V +1 04/30/24, 07:24

  9. core-ci voted on patch set 2 V +1 04/30/24, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57001

  10. Benjamin Franzke uploaded patch set 3 CR +1 V +1 04/30/24, 07:26

  11. Benjamin Kott voted on patch set 3 CR +1 V +1 04/30/24, 07:26

  12. core-ci voted on patch set 3 V +1 04/30/24, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57002

  13. Benjamin Franzke voted on patch set 3 CR +2 V +2 04/30/24, 07:31

  14. Benjamin Franzke merged patch set 4 04/30/24, 07:41