Review main Abandoned

84086[BUGFIX] Hide clearable icon to screen readers

Frank Nägler CR 0 V 0 Easy +2 −1 updated 04/30/24, 06:14

Commit message

This patch sets the clearable icon to `aria-hidden="true"`,
making it invisible to screen readers.
This element is optional and content can also be deleted
using the keyboard. This is an initial fix to improve
accessibility; further solutions may be developed later.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 68

  1. Frank Nägler uploaded patch set 1 04/29/24, 11:50

  2. Benjamin Kott voted on patch set 1 CR +1 V +1 04/29/24, 11:52

  3. core-ci voted on patch set 1 V +1 04/29/24, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56965

  4. Oliver Klee updated the commit message in patch set 2 CR +1 V +1 04/29/24, 12:04

  5. core-ci voted on patch set 2 V +1 04/29/24, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56966

  6. Benjamin Franzke commented on patch set 2 CR -1 04/30/24, 04:31

    Duplicate of > 83501: [TASK] Hide clear-input button from screenreaders | https://review.typo3.org/c/Packages/TYPO3.CMS/+/83501 But we can't merge that one right now, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/83501/1#message-805dd2df43346c7f88b62b4bccb65d8f82e9198c (leaving this open for now, to discuss later on how to proceed)
  7. Frank Nägler commented on patch set 2 04/30/24, 06:14

    Reply

    Thanks for the hint. I did not see the other patch. I will abandon my patch, and we will follow up on the patch from Willi.
  8. Frank Nägler abandoned the change 04/30/24, 06:14