Review main Merged

84087[TASK] Coloring the badges in "History/Undo" module

Jasmina Ließmann CR +2 V +2 Easy +11 −2 updated 05/02/24, 20:57

Commit message

Since #103670 the "Workspaces" module has a slightly different look.
In order to keep the "History/Undo" module visually synchronous, the
badges are now displayed in color - depending on the action type.

In addition, the label for the action type "add" was changed based on
the wording from the "Workspaces" module.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Chris Müller +1
    • Jörg Bösche +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Chris Müller +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 910

  1. Jasmina Ließmann uploaded patch set 1 04/29/24, 17:44

  2. core-ci voted on patch set 1 V +1 04/29/24, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56972

  3. Jörg Bösche voted on patch set 1 CR +1 04/30/24, 06:23

  4. Oliver Hader voted on patch set 1 CR +1 V +1 04/30/24, 20:47

  5. Georg Ringer commented on patch set 1 05/01/24, 07:05

    what about moving the class generation to ElementHistoryController::displayHistory with a little match expression and have less in fluid?
  6. Jasmina Ließmann commented on patch set 1 05/01/24, 08:49

    Reply

    I avoid styling things in classes/controllers whenever possible. In my opinion, only the functionality should be guaranteed there, but the design should happen outside (in this case in fluid).
  7. Chris Müller voted on patch set 1 CR +1 V +1 05/02/24, 17:43

  8. Jasmina Ließmann commented on patch set 1 05/02/24, 20:56

    Reply

    Done
  9. Jasmina Ließmann voted on patch set 1 CR +2 V +2 05/02/24, 20:57

  10. Jasmina Ließmann merged patch set 2 05/02/24, 20:57