Review main Merged

84097[TASK] Modernize Dashboard

Benjamin Kott CR +2 V +2 Nightmare +2701 −1458 updated 02/28/25, 09:57

Commit message

The dashboard is now fully usable via the keyboard, addressing A11Y
and usability reports. This change has been backported to the latest
LTS version, but not to older TYPO3 versions.

During initial tests, trying to implement moving widgets using keyboard
arrow keys, we discovered limitations. Widgets could not be moved in all
directions, resulting in linear sorting only. To resolve this, we
implemented a virtual grid system that allows widgets to be placed
freely.

Widgets can now occupy any position on the grid, and other elements
will move to the next logical place, mimicking natural movement. The
DOM's element ordering matches the visual alignment for consistent tab
navigation.

Breakpoints for small and medium devices now store their own positions
to avoid visual inconsistencies. Users can rearrange widgets based on
the viewport, allowing for better customization on mobile and desktop
environments. We have also limited the dashboard's maximum width,
providing developers with a reliable set of widths for designing
widgets.

Additionally, we are now using the HTML Drag and Drop API, preparing
for future enhancements. Currently, we do not support moving widgets
across windows or between dashboards, but this groundwork allows for
future development in newer versions.

By removing unnecessary page refreshes, we enhanced the user experience
by making the dashboard a reactive component, eliminating page loads
and focus loss.

This update aims to make the dashboard more fluent and enjoyable to use.

Commands executed:
  npm remove muuri
  npm install @lit-labs/motion
  npm run build

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 67

Show 47 more files

Review log 114199

Show 94174 earlier messages
  1. Benjamin Kott uploaded patch set 1 04/30/24, 13:41

  2. core-ci voted on patch set 1 V -1 04/30/24, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57016

  3. Benjamin Kott uploaded patch set 2 V -1 05/02/24, 11:56

  4. core-ci voted on patch set 2 V -1 05/02/24, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57091

  5. Benjamin Kott uploaded patch set 3 V -1 05/03/24, 14:31

  6. core-ci voted on patch set 3 V -1 05/03/24, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57174

  7. Benjamin Kott uploaded patch set 4 V -1 05/06/24, 11:51

  8. core-ci voted on patch set 4 V -1 05/06/24, 11:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57279

  9. Benjamin Kott uploaded patch set 5 V -1 05/06/24, 14:49

  10. core-ci voted on patch set 5 V -1 05/06/24, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57292

  11. Benjamin Kott uploaded patch set 6 V -1 05/07/24, 12:25

  12. core-ci voted on patch set 6 V -1 05/07/24, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57336

  13. Benjamin Kott uploaded patch set 7 V -1 05/07/24, 13:46

  14. core-ci voted on patch set 7 V -1 05/07/24, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57349

  15. Benjamin Kott uploaded patch set 8 V -1 05/07/24, 14:16

  16. core-ci voted on patch set 8 V -1 05/07/24, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57352

  17. Benjamin Kott uploaded patch set 9 V -1 05/22/24, 14:38

  18. Benjamin Kott uploaded patch set 10 05/22/24, 14:39

  19. core-ci voted on patch set 9 V -1 05/22/24, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58062

  20. core-ci voted on patch set 10 V -1 05/22/24, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58063

  21. Benjamin Kott uploaded patch set 11 V -1 05/23/24, 10:13

  22. core-ci voted on patch set 11 V -1 05/23/24, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58098

  23. Benjamin Kott uploaded patch set 12 V -1 05/29/24, 08:38

  24. core-ci voted on patch set 12 V -1 05/29/24, 08:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58439

  25. Christian Rath-Ulrich commented on patch set 12 06/12/24, 13:11

    hey @benjamin.kott@outlook.com Could you also include the changes from https://forge.typo3.org/issues/104070 here?
  26. Benjamin Kott uploaded patch set 13 V -1 11/20/24, 11:09

  27. core-ci voted on patch set 13 V -1 11/20/24, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69782

  28. Benni Mack marked it work in progress 01/24/25, 11:22

  29. Benjamin Kott uploaded patch set 14 V -1 02/04/25, 08:05

  30. core-ci voted on patch set 14 V -1 02/04/25, 08:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73466

  31. Benjamin Kott marked it ready for review 02/04/25, 08:41

  32. Benjamin Kott uploaded patch set 15 V -1 02/04/25, 14:55

  33. core-ci voted on patch set 15 V -1 02/04/25, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73506

  34. Benjamin Kott uploaded patch set 16 V -1 02/05/25, 10:22

  35. core-ci voted on patch set 16 V -1 02/05/25, 10:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73569

  36. Benjamin Kott uploaded patch set 17 V -1 02/05/25, 11:12

  37. core-ci voted on patch set 17 V -1 02/05/25, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73571

  38. Benjamin Kott uploaded patch set 18 V -1 02/05/25, 11:31

  39. core-ci voted on patch set 18 V -1 02/05/25, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73573

  40. Benjamin Kott uploaded patch set 19 V -1 02/05/25, 14:31

  41. core-ci voted on patch set 19 V -1 02/05/25, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73588

  42. Benjamin Kott uploaded patch set 20 V -1 02/11/25, 13:16

  43. core-ci voted on patch set 20 V -1 02/11/25, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73979

  44. Benjamin Kott uploaded patch set 21 V -1 02/14/25, 14:32

  45. core-ci voted on patch set 21 V -1 02/14/25, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74153

  46. Benjamin Kott uploaded patch set 22 V -1 02/18/25, 12:00

  47. core-ci voted on patch set 22 V -1 02/18/25, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74307

  48. Benjamin Kott uploaded patch set 23 V -1 02/18/25, 12:13

  49. core-ci voted on patch set 23 V -1 02/18/25, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74310

  50. Benjamin Kott uploaded patch set 24 V -1 02/18/25, 13:45

  51. core-ci voted on patch set 24 V -1 02/18/25, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74318

  52. Benjamin Kott uploaded patch set 25 V -1 02/19/25, 12:15

  53. core-ci voted on patch set 25 V -1 02/19/25, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74382

  54. Benjamin Kott uploaded patch set 26 V -1 02/19/25, 12:47

  55. core-ci voted on patch set 26 V -1 02/19/25, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74385

  56. Benjamin Kott uploaded patch set 27 V -1 02/19/25, 13:13

  57. Benjamin Kott uploaded patch set 28 02/19/25, 13:18

  58. core-ci voted on patch set 27 V -1 02/19/25, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74386

  59. core-ci voted on patch set 28 V -1 02/19/25, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74387

  60. Benjamin Kott uploaded patch set 29 V -1 02/19/25, 13:26

  61. core-ci voted on patch set 29 V -1 02/19/25, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74388

  62. Benjamin Kott uploaded patch set 30 V -1 02/19/25, 16:27

  63. core-ci voted on patch set 30 V -1 02/19/25, 16:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74403

  64. Benjamin Franzke commented on patch set 30 CR -2 02/20/25, 08:57

    ext_tables.sql:6

    No new fields in bugfix releases please. Can we merge this into `widgets`?
  65. Benjamin Franzke commented on patch set 30 CR 0 02/20/25, 09:25

    ♥️
  66. Benjamin Kott uploaded patch set 31 V -1 02/20/25, 09:37

  67. Benjamin Kott commented on patch set 31 02/20/25, 09:39

    ext_tables.sql:6 Reply

    Done
  68. core-ci voted on patch set 31 V -1 02/20/25, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74455

  69. Benjamin Franzke uploaded patch set 32 V -1 02/21/25, 09:20

  70. core-ci voted on patch set 32 V -1 02/21/25, 09:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74493

  71. Benjamin Kott uploaded patch set 33 V -1 02/21/25, 10:28

  72. core-ci voted on patch set 33 V -1 02/21/25, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74495

  73. Benjamin Kott uploaded patch set 34 V -1 02/21/25, 10:37

  74. core-ci voted on patch set 34 V -1 02/21/25, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74496

  75. Benjamin Kott uploaded patch set 35 V -1 02/21/25, 11:02

  76. Benjamin Kott uploaded patch set 36 02/21/25, 11:06

  77. core-ci voted on patch set 35 V -1 02/21/25, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74499

  78. core-ci voted on patch set 36 V -1 02/21/25, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74501

  79. Benjamin Kott uploaded patch set 37 V -1 02/21/25, 14:57

  80. core-ci voted on patch set 37 V -1 02/21/25, 15:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74520

  81. Benjamin Franzke uploaded patch set 38 V -1 02/24/25, 08:23

  82. core-ci voted on patch set 38 V -1 02/24/25, 08:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74611

  83. Benjamin Kott uploaded patch set 39 V -1 02/24/25, 09:56

  84. core-ci voted on patch set 39 V -1 02/24/25, 10:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74614

  85. Benjamin Franzke uploaded patch set 40 V -1 02/24/25, 11:22

  86. core-ci voted on patch set 40 V -1 02/24/25, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74620

  87. Benjamin Franzke uploaded patch set 41 V -1 02/24/25, 11:41

  88. core-ci voted on patch set 41 V -1 02/24/25, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74621

  89. Benjamin Kott uploaded patch set 42 V -1 02/24/25, 13:15

  90. core-ci voted on patch set 42 V -1 02/24/25, 13:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74622

  91. Benjamin Kott uploaded patch set 43 V -1 02/24/25, 13:28

  92. core-ci voted on patch set 43 V -1 02/24/25, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74623

  93. Benjamin Franzke uploaded patch set 44 V -1 02/24/25, 13:38

  94. core-ci voted on patch set 44 V -1 02/24/25, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74624

  95. Benjamin Kott uploaded patch set 45 V -1 02/24/25, 13:47

  96. core-ci voted on patch set 45 V -1 02/24/25, 13:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74625

  97. Benjamin Kott uploaded patch set 46 V -1 02/24/25, 14:16

  98. core-ci voted on patch set 46 V -1 02/24/25, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74627

  99. Benjamin Franzke uploaded patch set 47 V -1 02/24/25, 16:48

  100. core-ci voted on patch set 47 V -1 02/24/25, 16:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74628

  101. Benjamin Franzke uploaded patch set 48 V -1 02/24/25, 17:41

  102. core-ci voted on patch set 48 V -1 02/24/25, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74630

  103. Benjamin Franzke uploaded patch set 49 V -1 02/24/25, 17:48

  104. core-ci voted on patch set 49 V +1 02/24/25, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74631

  105. Benjamin Franzke uploaded patch set 50 V +1 02/24/25, 21:55

  106. core-ci voted on patch set 50 V +1 02/24/25, 22:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74642

  107. Benjamin Franzke uploaded patch set 51 V +1 02/25/25, 05:44

  108. core-ci voted on patch set 51 V +1 02/25/25, 05:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74661

  109. Benjamin Franzke uploaded patch set 52 V +1 02/25/25, 08:22

  110. core-ci voted on patch set 52 V -1 02/25/25, 08:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74663

  111. Benjamin Franzke uploaded patch set 53 V -1 02/25/25, 08:59

  112. Benjamin Franzke uploaded patch set 54 02/25/25, 09:00

  113. core-ci voted on patch set 53 V -1 02/25/25, 09:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74665

  114. core-ci voted on patch set 54 V -1 02/25/25, 09:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74666

  115. Benjamin Kott uploaded patch set 55 V -1 02/25/25, 09:53

  116. core-ci voted on patch set 55 V -1 02/25/25, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74668

  117. Benjamin Kott uploaded patch set 56 V -1 02/25/25, 11:34

  118. core-ci voted on patch set 56 V -1 02/25/25, 11:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74676

  119. Benjamin Kott uploaded patch set 57 V -1 02/25/25, 12:59

  120. core-ci voted on patch set 57 V +1 02/25/25, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74678

  121. Benjamin Franzke uploaded patch set 58 V +1 02/25/25, 13:15

  122. core-ci voted on patch set 58 V +1 02/25/25, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74679

  123. Benjamin Kott uploaded patch set 59 V +1 02/25/25, 14:35

  124. core-ci voted on patch set 59 V -1 02/25/25, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74680

  125. Benjamin Kott uploaded patch set 60 V -1 02/25/25, 14:42

  126. Benjamin Kott uploaded patch set 61 02/25/25, 14:47

  127. core-ci voted on patch set 60 V -1 02/25/25, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74682

  128. core-ci voted on patch set 61 V -1 02/25/25, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74684

  129. Benjamin Kott uploaded patch set 62 V -1 02/25/25, 14:59

  130. core-ci voted on patch set 62 V +1 02/25/25, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74685

  131. Benjamin Franzke uploaded patch set 63 V +1 02/26/25, 06:14

  132. core-ci voted on patch set 63 V +1 02/26/25, 06:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74723

  133. Benjamin Franzke uploaded patch set 64 V +1 02/26/25, 07:19

  134. Benjamin Franzke uploaded patch set 65 02/26/25, 07:25

  135. core-ci voted on patch set 64 V -1 02/26/25, 07:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74725

  136. Benjamin Franzke uploaded patch set 66 02/26/25, 07:29

  137. core-ci voted on patch set 66 V +1 02/26/25, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74727

  138. Benjamin Franzke uploaded patch set 67 V +1 02/26/25, 08:50

  139. core-ci voted on patch set 67 V +1 02/26/25, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74731

  140. Benjamin Kott uploaded patch set 68 V +1 02/26/25, 09:11

  141. Benjamin Kott updated the commit message in patch set 69 02/26/25, 09:13

  142. core-ci voted on patch set 68 V +1 02/26/25, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74737

  143. core-ci voted on patch set 69 V +1 02/26/25, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74738

  144. Benjamin Franzke uploaded patch set 70 V +1 02/26/25, 10:15

  145. core-ci voted on patch set 70 V -1 02/26/25, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74746

  146. Andreas Kienast commented on patch set 70 CR -1 02/26/25, 11:07

    _modal.scss:29

    Why do we need this?

    dashboard.ts:210

    Many of those are left here.

    dashboard.ts:1003

    them them

    dashboard.ts:1006

    Left over code

    dashboard.ts:1217

    Deprecation.rst is missing
  147. Benjamin Franzke uploaded patch set 71 CR -1 V -1 02/26/25, 11:55

  148. Benjamin Franzke commented on patch set 71 02/26/25, 11:55

    _modal.scss:29 Reply

    This is used in the dashboard-add modal. The labels need to be clickable, but the label contents should not be selectable.

    dashboard.ts:1003 Reply

    Done

    dashboard.ts:1006 Reply

    Done

    dashboard.ts:1217 Reply

    Done
  149. core-ci voted on patch set 71 V +1 02/26/25, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74754

  150. Benjamin Franzke uploaded patch set 72 V +1 02/26/25, 12:33

  151. Benjamin Franzke commented on patch set 72 02/26/25, 12:33

    dashboard.ts:210 Reply

    Done
  152. core-ci voted on patch set 72 V -1 02/26/25, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74757

  153. Benjamin Franzke uploaded patch set 73 V -1 02/26/25, 12:39

  154. core-ci voted on patch set 73 V +1 02/26/25, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74758

  155. Benjamin Franzke uploaded patch set 74 V +1 02/26/25, 13:08

  156. Benjamin Franzke uploaded patch set 75 02/26/25, 13:13

  157. core-ci voted on patch set 74 V +1 02/26/25, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74760

  158. core-ci voted on patch set 75 V +1 02/26/25, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74761

  159. Benjamin Franzke uploaded patch set 76 V +1 02/26/25, 13:46

  160. core-ci voted on patch set 76 V +1 02/26/25, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74762

  161. Benjamin Franzke uploaded patch set 77 V +1 02/26/25, 14:08

  162. core-ci voted on patch set 77 V +1 02/26/25, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74765

  163. Andreas Kienast voted on patch set 77 CR +1 V +1 02/27/25, 08:13

  164. Benjamin Franzke commented on patch set 77 CR -1 02/27/25, 08:13

    on it
  165. Andreas Kienast commented on patch set 77 CR 0 V 0 02/27/25, 08:13

    Still WIP
  166. Benjamin Franzke uploaded patch set 78 CR -1 V +1 02/27/25, 09:08

  167. core-ci voted on patch set 78 V -1 02/27/25, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74823

  168. Benjamin Franzke uploaded patch set 79 V -1 02/27/25, 09:20

  169. core-ci voted on patch set 79 V +1 02/27/25, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74826

  170. Benjamin Kott uploaded patch set 80 V +1 02/27/25, 11:10

  171. core-ci voted on patch set 80 V +1 02/27/25, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74829

  172. Benjamin Franzke uploaded patch set 81 V +1 02/27/25, 12:29

  173. core-ci voted on patch set 81 V +1 02/27/25, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74830

  174. Benjamin Franzke uploaded patch set 82 V +1 02/27/25, 12:35

  1. core-ci voted on patch set 82 V +1 02/27/25, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74831

  2. Benni Mack commented on patch set 82 02/27/25, 15:31

    Dashboard.php:20

    I suggest to either explain what "Transfer" means (I have no clue, but I guess it's a DTO)... or we need to define these classes "@internal"

    Dashboard.php:21

    I guess this class can be "final readonly class Dashboard"
  3. Benjamin Franzke uploaded patch set 83 V +1 02/27/25, 19:52

  4. Benjamin Franzke commented on patch set 83 02/27/25, 19:52

    Dashboard.php:20 Reply

    ack, DataTransferObject (every class is a object and data is implied by being readonly, therefore benji used `Transfer`). Anyway, renamed to DTO to streamline with tree dto's and marked internal.

    Dashboard.php:21 Reply

    Done
  5. core-ci voted on patch set 83 V +1 02/27/25, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74843

  6. Benni Mack commented on patch set 83 CR +1 V +1 02/27/25, 20:04

    I lack the JS skills to do a full blown code review on the JS+CSS part, but the rest looks good and very exciting. Thanks for the efforts here!

    Dashboard.php:20 Reply

    thought so ;) Good, now we're streamlined a bit more.
  7. Benjamin Franzke voted on patch set 83 CR +1 V +1 02/27/25, 21:19

  8. Benjamin Franzke uploaded patch set 84 CR +1 V +1 02/27/25, 23:07

  9. Benjamin Franzke voted on patch set 84 CR +1 V +1 02/27/25, 23:09

  10. core-ci voted on patch set 84 V +1 02/27/25, 23:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74849

  11. Simon Schaufelberger commented on patch set 84 02/28/25, 00:47

    Having a 4k monitor and 27", I have a lot of white space now on the sides of the widgets. I have read the reasons to have a fixed width, I just wanted to give my personal feedback that I'm not a big fan of fixed width widgets. Especially the graphs are a lot smaller now and harder to read. I would propose a max-width of the dashboard-container of 2400px and then add more breakpoints. Can't we use the breakpoints from bootstrap here? I've also compared the width of the dashboard with the maintenance and the reports modules and they are different. The breakpoint of then the 2 widgets side by side go below each other is also not optimal imho. Right at this point, the widgets are squeezed too much.
  12. Benjamin Kott commented on patch set 84 02/28/25, 08:48

    Reply

    I currently run a 34" WQHD Ultra-Widescreen - and the current dashboard is pretty unusable for me. But I also consider my resolution as the minority of users that can be considered an edge case. We are aware that we can make better use of the space, if it´s available. But this will not make it into this patch and probably not v13 as we tried to at least keep some guidelines on how it is currently used. We prepared the structure to be capable of handling the following in the future: Resizing of widgets while respecting the minimum size of a widget, that means that the current settings for widgets will be seen as a minimum config, and we will be able to change dimensions of a widget in the future (stored per viewpoint). We prepared the codebase that we can allow more than the current 4 columns in the future. This will allow better usage of the space, but we feared that it will distort current dashboards and wanted to see how it works out when we implement the resizing. For now, the goal of the dashboard is to be responsive, and it behaves more or less the same as before in terms of scaling of widgets / and viewport resizes except the max width on the container. We will see how this works out and are open to make adjustments when we see how it´s received. With the new base widths for widgets, we at least have something the developer can design their widgets around, and yes, they also need to consider mobile usage.
  13. Benni Mack commented on patch set 84 CR +1 V +1 02/28/25, 08:54

    agreed. let's get this large change in and then do the fine-tuning later.
  14. Benjamin Kott commented on patch set 84 CR -1 02/28/25, 08:57

    on it
  15. Benjamin Kott uploaded patch set 85 CR +1 V +1 02/28/25, 09:08

  16. Benjamin Franzke voted on patch set 85 CR +1 V +1 02/28/25, 09:09

  17. core-ci voted on patch set 85 V +1 02/28/25, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74876

  18. Benni Mack voted on patch set 85 CR +1 V +1 02/28/25, 09:25

  19. Benjamin Kott voted on patch set 85 CR +2 V +2 02/28/25, 09:32

  20. Benjamin Kott uploaded patch set 86 CR +1 V +1 02/28/25, 09:39

  21. Benjamin Franzke uploaded patch set 87 02/28/25, 09:40

  22. Benni Mack voted on patch set 87 CR +1 V +1 02/28/25, 09:43

  23. core-ci voted on patch set 87 V +1 02/28/25, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74883

  24. Benjamin Kott voted on patch set 87 CR +2 V +2 02/28/25, 09:56

  25. Benjamin Kott merged patch set 88 02/28/25, 09:57