84097[TASK] Modernize Dashboard
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 67
- Build/phpstan/phpstan-baseline.neon+0 −12
- Build/Sources/Sass/dashboard/_button.scss+1 −39
- Build/Sources/Sass/dashboard/_empty.scss+3 −2
- Build/Sources/Sass/dashboard/_grid.scss+54 −93
- Build/Sources/Sass/dashboard/_header.scss+17 −1
- Build/Sources/Sass/dashboard/_widget.scss+43 −25
- Build/Sources/Sass/dashboard_modal/_modal.scss2+40 −27
- Build/Sources/TypeScript/backend/utility/dom-helper.ts+7 −3
- Build/Sources/TypeScript/backend/new-record-wizard.ts+27 −9
- Build/Sources/TypeScript/core/lit-helper.ts+16 −2
- Build/Sources/TypeScript/dashboard/chart-initializer.ts+11 −2
- Build/Sources/TypeScript/dashboard/dashboard-delete.tsdeleted+0 −59
- Build/Sources/TypeScript/dashboard/dashboard-modal.tsdeleted+0 −72
- Build/Sources/TypeScript/dashboard/dashboard.ts8new+1487 −0
- Build/Sources/TypeScript/dashboard/grid.tsdeleted+0 −93
- Build/Sources/TypeScript/dashboard/widget-content-collector.tsdeleted+0 −93
- Build/Sources/TypeScript/dashboard/widget-refresh.tsdeleted+0 −68
- Build/Sources/TypeScript/dashboard/widget-remover.tsdeleted+0 −59
- Build/Sources/TypeScript/dashboard/widget-selector.tsdeleted+0 −76
- Build/util/map-import.js+1 −1
Show 47 more files
- Build/Gruntfile.js+4 −19
- Build/package-lock.json+10 −6
- Build/package.json+1 −1
- Build/tsconfig.json+1 −0
- Build/web-test-runner.config.mjs+2 −1
- typo3/sysext/backend/Configuration/ContentSecurityPolicies.php+0 −2
- typo3/sysext/backend/Resources/Private/Partials/About/ExternalLibraries.html+0 −4
- typo3/sysext/backend/Resources/Public/JavaScript/utility/dom-helper.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/new-record-wizard.js+2 −2
- typo3/sysext/core/Configuration/JavaScriptModules.php+3 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit-labs/motion/animate-controller.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit-labs/motion/animate.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit-labs/motion/index.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit-labs/motion/position.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/lit-helper.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Dashboard/DashboardModuleCest.php+9 −9
- typo3/sysext/dashboard/Classes/Controller/DashboardAjaxController.phpnew+401 −0
- typo3/sysext/dashboard/Classes/Controller/DashboardController.php+6 −132
- typo3/sysext/dashboard/Classes/Controller/WidgetAjaxController.phpdeleted+0 −87
- typo3/sysext/dashboard/Classes/Dto/Dashboard.phpnew+41 −0
- typo3/sysext/dashboard/Classes/Dto/WidgetConfiguration.phpnew+41 −0
- typo3/sysext/dashboard/Classes/Dto/WidgetData.phpnew+49 −0
- typo3/sysext/dashboard/Classes/Dto/WidgetPosition.phpnew+43 −0
- typo3/sysext/dashboard/Classes/Dashboard.php+32 −1
- typo3/sysext/dashboard/Classes/DashboardInitializationService.php+16 −30
- typo3/sysext/dashboard/Classes/DashboardPreset.php+14 −1
- typo3/sysext/dashboard/Classes/DashboardRepository.php+4 −1
- typo3/sysext/dashboard/Classes/WidgetGroupInitializationService.php+2 −6
- typo3/sysext/dashboard/Configuration/Backend/AjaxRoutes.php+57 −8
- typo3/sysext/dashboard/Configuration/Backend/Modules.php+1 −1
- typo3/sysext/dashboard/Configuration/JavaScriptModules.php+0 −1
- typo3/sysext/dashboard/Resources/Private/Language/locallang.xlf+10 −1
- typo3/sysext/dashboard/Resources/Private/Layouts/Widget/Widget.html+0 −1
- typo3/sysext/dashboard/Resources/Private/Layouts/Module.htmldeleted+0 −81
- typo3/sysext/dashboard/Resources/Private/Templates/Dashboard/Main.html+2 −155
- typo3/sysext/dashboard/Resources/Public/Css/Modal/style.css+9 −7
- typo3/sysext/dashboard/Resources/Public/Css/dashboard.css+25 −46
- typo3/sysext/dashboard/Resources/Public/JavaScript/Contrib/muuri.jsdeleted+0 −25
- typo3/sysext/dashboard/Resources/Public/JavaScript/chart-initializer.js+1 −1
- typo3/sysext/dashboard/Resources/Public/JavaScript/dashboard-delete.jsdeleted+0 −13
- typo3/sysext/dashboard/Resources/Public/JavaScript/dashboard-modal.jsdeleted+0 −13
- typo3/sysext/dashboard/Resources/Public/JavaScript/dashboard.jsnew+202 −0
- typo3/sysext/dashboard/Resources/Public/JavaScript/grid.jsdeleted+0 −13
- typo3/sysext/dashboard/Resources/Public/JavaScript/widget-content-collector.jsdeleted+0 −13
- typo3/sysext/dashboard/Resources/Public/JavaScript/widget-refresh.jsdeleted+0 −13
- typo3/sysext/dashboard/Resources/Public/JavaScript/widget-remover.jsdeleted+0 −13
- typo3/sysext/dashboard/Resources/Public/JavaScript/widget-selector.jsdeleted+0 −13
Review log 114199
Show 94174 earlier messages
-
Benjamin Kott uploaded patch set 1 04/30/24, 13:41
-
core-ci voted on patch set 1 V -1 04/30/24, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57016
-
Benjamin Kott uploaded patch set 2
V -105/02/24, 11:56 -
core-ci voted on patch set 2 V -1 05/02/24, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57091
-
Benjamin Kott uploaded patch set 3
V -105/03/24, 14:31 -
core-ci voted on patch set 3 V -1 05/03/24, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57174
-
Benjamin Kott uploaded patch set 4
V -105/06/24, 11:51 -
core-ci voted on patch set 4 V -1 05/06/24, 11:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57279
-
Benjamin Kott uploaded patch set 5
V -105/06/24, 14:49 -
core-ci voted on patch set 5 V -1 05/06/24, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57292
-
Benjamin Kott uploaded patch set 6
V -105/07/24, 12:25 -
core-ci voted on patch set 6 V -1 05/07/24, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57336
-
Benjamin Kott uploaded patch set 7
V -105/07/24, 13:46 -
core-ci voted on patch set 7 V -1 05/07/24, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57349
-
Benjamin Kott uploaded patch set 8
V -105/07/24, 14:16 -
core-ci voted on patch set 8 V -1 05/07/24, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57352
-
Benjamin Kott uploaded patch set 9
V -105/22/24, 14:38 -
Benjamin Kott uploaded patch set 10 05/22/24, 14:39
-
core-ci voted on patch set 9 V -1 05/22/24, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58062
-
core-ci voted on patch set 10 V -1 05/22/24, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58063
-
Benjamin Kott uploaded patch set 11
V -105/23/24, 10:13 -
core-ci voted on patch set 11 V -1 05/23/24, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58098
-
Benjamin Kott uploaded patch set 12
V -105/29/24, 08:38 -
core-ci voted on patch set 12 V -1 05/29/24, 08:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58439
-
Christian Rath-Ulrich commented on patch set 12 06/12/24, 13:11
hey @benjamin.kott@outlook.com Could you also include the changes from https://forge.typo3.org/issues/104070 here? -
Benjamin Kott uploaded patch set 13
V -111/20/24, 11:09 -
core-ci voted on patch set 13 V -1 11/20/24, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69782
-
Benni Mack marked it work in progress 01/24/25, 11:22
-
Benjamin Kott uploaded patch set 14
V -102/04/25, 08:05 -
core-ci voted on patch set 14 V -1 02/04/25, 08:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73466
-
Benjamin Kott marked it ready for review 02/04/25, 08:41
-
Benjamin Kott uploaded patch set 15
V -102/04/25, 14:55 -
core-ci voted on patch set 15 V -1 02/04/25, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73506
-
Benjamin Kott uploaded patch set 16
V -102/05/25, 10:22 -
core-ci voted on patch set 16 V -1 02/05/25, 10:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73569
-
Benjamin Kott uploaded patch set 17
V -102/05/25, 11:12 -
core-ci voted on patch set 17 V -1 02/05/25, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73571
-
Benjamin Kott uploaded patch set 18
V -102/05/25, 11:31 -
core-ci voted on patch set 18 V -1 02/05/25, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73573
-
Benjamin Kott uploaded patch set 19
V -102/05/25, 14:31 -
core-ci voted on patch set 19 V -1 02/05/25, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73588
-
Benjamin Kott uploaded patch set 20
V -102/11/25, 13:16 -
core-ci voted on patch set 20 V -1 02/11/25, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73979
-
Benjamin Kott uploaded patch set 21
V -102/14/25, 14:32 -
core-ci voted on patch set 21 V -1 02/14/25, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74153
-
Benjamin Kott uploaded patch set 22
V -102/18/25, 12:00 -
core-ci voted on patch set 22 V -1 02/18/25, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74307
-
Benjamin Kott uploaded patch set 23
V -102/18/25, 12:13 -
core-ci voted on patch set 23 V -1 02/18/25, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74310
-
Benjamin Kott uploaded patch set 24
V -102/18/25, 13:45 -
core-ci voted on patch set 24 V -1 02/18/25, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74318
-
Benjamin Kott uploaded patch set 25
V -102/19/25, 12:15 -
core-ci voted on patch set 25 V -1 02/19/25, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74382
-
Benjamin Kott uploaded patch set 26
V -102/19/25, 12:47 -
core-ci voted on patch set 26 V -1 02/19/25, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74385
-
Benjamin Kott uploaded patch set 27
V -102/19/25, 13:13 -
Benjamin Kott uploaded patch set 28 02/19/25, 13:18
-
core-ci voted on patch set 27 V -1 02/19/25, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74386
-
core-ci voted on patch set 28 V -1 02/19/25, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74387
-
Benjamin Kott uploaded patch set 29
V -102/19/25, 13:26 -
core-ci voted on patch set 29 V -1 02/19/25, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74388
-
Benjamin Kott uploaded patch set 30
V -102/19/25, 16:27 -
core-ci voted on patch set 30 V -1 02/19/25, 16:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74403
-
Benjamin Franzke commented on patch set 30 CR -2 02/20/25, 08:57
ext_tables.sql:6No new fields in bugfix releases please. Can we merge this into `widgets`? -
Benjamin Franzke commented on patch set 30 CR 0 02/20/25, 09:25
♥️ -
Benjamin Kott uploaded patch set 31
V -102/20/25, 09:37 -
Benjamin Kott commented on patch set 31 02/20/25, 09:39
ext_tables.sql:6ReplyDone -
core-ci voted on patch set 31 V -1 02/20/25, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74455
-
Benjamin Franzke uploaded patch set 32
V -102/21/25, 09:20 -
core-ci voted on patch set 32 V -1 02/21/25, 09:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74493
-
Benjamin Kott uploaded patch set 33
V -102/21/25, 10:28 -
core-ci voted on patch set 33 V -1 02/21/25, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74495
-
Benjamin Kott uploaded patch set 34
V -102/21/25, 10:37 -
core-ci voted on patch set 34 V -1 02/21/25, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74496
-
Benjamin Kott uploaded patch set 35
V -102/21/25, 11:02 -
Benjamin Kott uploaded patch set 36 02/21/25, 11:06
-
core-ci voted on patch set 35 V -1 02/21/25, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74499
-
core-ci voted on patch set 36 V -1 02/21/25, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74501
-
Benjamin Kott uploaded patch set 37
V -102/21/25, 14:57 -
core-ci voted on patch set 37 V -1 02/21/25, 15:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74520
-
Benjamin Franzke uploaded patch set 38
V -102/24/25, 08:23 -
core-ci voted on patch set 38 V -1 02/24/25, 08:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74611
-
Benjamin Kott uploaded patch set 39
V -102/24/25, 09:56 -
core-ci voted on patch set 39 V -1 02/24/25, 10:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74614
-
Benjamin Franzke uploaded patch set 40
V -102/24/25, 11:22 -
core-ci voted on patch set 40 V -1 02/24/25, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74620
-
Benjamin Franzke uploaded patch set 41
V -102/24/25, 11:41 -
core-ci voted on patch set 41 V -1 02/24/25, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74621
-
Benjamin Kott uploaded patch set 42
V -102/24/25, 13:15 -
core-ci voted on patch set 42 V -1 02/24/25, 13:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74622
-
Benjamin Kott uploaded patch set 43
V -102/24/25, 13:28 -
core-ci voted on patch set 43 V -1 02/24/25, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74623
-
Benjamin Franzke uploaded patch set 44
V -102/24/25, 13:38 -
core-ci voted on patch set 44 V -1 02/24/25, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74624
-
Benjamin Kott uploaded patch set 45
V -102/24/25, 13:47 -
core-ci voted on patch set 45 V -1 02/24/25, 13:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74625
-
Benjamin Kott uploaded patch set 46
V -102/24/25, 14:16 -
core-ci voted on patch set 46 V -1 02/24/25, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74627
-
Benjamin Franzke uploaded patch set 47
V -102/24/25, 16:48 -
core-ci voted on patch set 47 V -1 02/24/25, 16:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74628
-
Benjamin Franzke uploaded patch set 48
V -102/24/25, 17:41 -
core-ci voted on patch set 48 V -1 02/24/25, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74630
-
Benjamin Franzke uploaded patch set 49
V -102/24/25, 17:48 -
core-ci voted on patch set 49 V +1 02/24/25, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74631
-
Benjamin Franzke uploaded patch set 50
V +102/24/25, 21:55 -
core-ci voted on patch set 50 V +1 02/24/25, 22:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74642
-
Benjamin Franzke uploaded patch set 51
V +102/25/25, 05:44 -
core-ci voted on patch set 51 V +1 02/25/25, 05:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74661
-
Benjamin Franzke uploaded patch set 52
V +102/25/25, 08:22 -
core-ci voted on patch set 52 V -1 02/25/25, 08:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74663
-
Benjamin Franzke uploaded patch set 53
V -102/25/25, 08:59 -
Benjamin Franzke uploaded patch set 54 02/25/25, 09:00
-
core-ci voted on patch set 53 V -1 02/25/25, 09:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74665
-
core-ci voted on patch set 54 V -1 02/25/25, 09:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74666
-
Benjamin Kott uploaded patch set 55
V -102/25/25, 09:53 -
core-ci voted on patch set 55 V -1 02/25/25, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74668
-
Benjamin Kott uploaded patch set 56
V -102/25/25, 11:34 -
core-ci voted on patch set 56 V -1 02/25/25, 11:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74676
-
Benjamin Kott uploaded patch set 57
V -102/25/25, 12:59 -
core-ci voted on patch set 57 V +1 02/25/25, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74678
-
Benjamin Franzke uploaded patch set 58
V +102/25/25, 13:15 -
core-ci voted on patch set 58 V +1 02/25/25, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74679
-
Benjamin Kott uploaded patch set 59
V +102/25/25, 14:35 -
core-ci voted on patch set 59 V -1 02/25/25, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74680
-
Benjamin Kott uploaded patch set 60
V -102/25/25, 14:42 -
Benjamin Kott uploaded patch set 61 02/25/25, 14:47
-
core-ci voted on patch set 60 V -1 02/25/25, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74682
-
core-ci voted on patch set 61 V -1 02/25/25, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74684
-
Benjamin Kott uploaded patch set 62
V -102/25/25, 14:59 -
core-ci voted on patch set 62 V +1 02/25/25, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74685
-
Benjamin Franzke uploaded patch set 63
V +102/26/25, 06:14 -
core-ci voted on patch set 63 V +1 02/26/25, 06:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74723
-
Benjamin Franzke uploaded patch set 64
V +102/26/25, 07:19 -
Benjamin Franzke uploaded patch set 65 02/26/25, 07:25
-
core-ci voted on patch set 64 V -1 02/26/25, 07:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74725
-
Benjamin Franzke uploaded patch set 66 02/26/25, 07:29
-
core-ci voted on patch set 66 V +1 02/26/25, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74727
-
Benjamin Franzke uploaded patch set 67
V +102/26/25, 08:50 -
core-ci voted on patch set 67 V +1 02/26/25, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74731
-
Benjamin Kott uploaded patch set 68
V +102/26/25, 09:11 -
Benjamin Kott updated the commit message in patch set 69 02/26/25, 09:13
-
core-ci voted on patch set 68 V +1 02/26/25, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74737
-
core-ci voted on patch set 69 V +1 02/26/25, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74738
-
Benjamin Franzke uploaded patch set 70
V +102/26/25, 10:15 -
core-ci voted on patch set 70 V -1 02/26/25, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74746
-
Andreas Kienast commented on patch set 70 CR -1 02/26/25, 11:07
_modal.scss:29Why do we need this?dashboard.ts:210Many of those are left here.dashboard.ts:1003them themdashboard.ts:1006Left over codedashboard.ts:1217Deprecation.rst is missing -
Benjamin Franzke uploaded patch set 71
CR -1V -102/26/25, 11:55 -
Benjamin Franzke commented on patch set 71 02/26/25, 11:55
_modal.scss:29ReplyThis is used in the dashboard-add modal. The labels need to be clickable, but the label contents should not be selectable.dashboard.ts:1003ReplyDonedashboard.ts:1006ReplyDonedashboard.ts:1217ReplyDone -
core-ci voted on patch set 71 V +1 02/26/25, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74754
-
Benjamin Franzke uploaded patch set 72
V +102/26/25, 12:33 -
Benjamin Franzke commented on patch set 72 02/26/25, 12:33
dashboard.ts:210ReplyDone -
core-ci voted on patch set 72 V -1 02/26/25, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74757
-
Benjamin Franzke uploaded patch set 73
V -102/26/25, 12:39 -
core-ci voted on patch set 73 V +1 02/26/25, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74758
-
Benjamin Franzke uploaded patch set 74
V +102/26/25, 13:08 -
Benjamin Franzke uploaded patch set 75 02/26/25, 13:13
-
core-ci voted on patch set 74 V +1 02/26/25, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74760
-
core-ci voted on patch set 75 V +1 02/26/25, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74761
-
Benjamin Franzke uploaded patch set 76
V +102/26/25, 13:46 -
core-ci voted on patch set 76 V +1 02/26/25, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74762
-
Benjamin Franzke uploaded patch set 77
V +102/26/25, 14:08 -
core-ci voted on patch set 77 V +1 02/26/25, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74765
-
Andreas Kienast voted on patch set 77 CR +1 V +1 02/27/25, 08:13
-
Benjamin Franzke commented on patch set 77 CR -1 02/27/25, 08:13
on it -
Andreas Kienast commented on patch set 77 CR 0 V 0 02/27/25, 08:13
Still WIP -
Benjamin Franzke uploaded patch set 78
CR -1V +102/27/25, 09:08 -
core-ci voted on patch set 78 V -1 02/27/25, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74823
-
Benjamin Franzke uploaded patch set 79
V -102/27/25, 09:20 -
core-ci voted on patch set 79 V +1 02/27/25, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74826
-
Benjamin Kott uploaded patch set 80
V +102/27/25, 11:10 -
core-ci voted on patch set 80 V +1 02/27/25, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74829
-
Benjamin Franzke uploaded patch set 81
V +102/27/25, 12:29 -
core-ci voted on patch set 81 V +1 02/27/25, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74830
-
Benjamin Franzke uploaded patch set 82
V +102/27/25, 12:35
-
core-ci voted on patch set 82 V +1 02/27/25, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74831
-
Benni Mack commented on patch set 82 02/27/25, 15:31
Dashboard.php:20I suggest to either explain what "Transfer" means (I have no clue, but I guess it's a DTO)... or we need to define these classes "@internal"Dashboard.php:21I guess this class can be "final readonly class Dashboard" -
Benjamin Franzke uploaded patch set 83
V +102/27/25, 19:52 -
Benjamin Franzke commented on patch set 83 02/27/25, 19:52
Dashboard.php:20Replyack, DataTransferObject (every class is a object and data is implied by being readonly, therefore benji used `Transfer`). Anyway, renamed to DTO to streamline with tree dto's and marked internal.Dashboard.php:21ReplyDone -
core-ci voted on patch set 83 V +1 02/27/25, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74843
-
Benni Mack commented on patch set 83 CR +1 V +1 02/27/25, 20:04
I lack the JS skills to do a full blown code review on the JS+CSS part, but the rest looks good and very exciting. Thanks for the efforts here!Dashboard.php:20Replythought so ;) Good, now we're streamlined a bit more. -
Benjamin Franzke voted on patch set 83 CR +1 V +1 02/27/25, 21:19
-
Benjamin Franzke uploaded patch set 84
CR +1V +102/27/25, 23:07 -
Benjamin Franzke voted on patch set 84 CR +1 V +1 02/27/25, 23:09
-
core-ci voted on patch set 84 V +1 02/27/25, 23:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74849
-
Simon Schaufelberger commented on patch set 84 02/28/25, 00:47
Having a 4k monitor and 27", I have a lot of white space now on the sides of the widgets. I have read the reasons to have a fixed width, I just wanted to give my personal feedback that I'm not a big fan of fixed width widgets. Especially the graphs are a lot smaller now and harder to read. I would propose a max-width of the dashboard-container of 2400px and then add more breakpoints. Can't we use the breakpoints from bootstrap here? I've also compared the width of the dashboard with the maintenance and the reports modules and they are different. The breakpoint of then the 2 widgets side by side go below each other is also not optimal imho. Right at this point, the widgets are squeezed too much. -
Benjamin Kott commented on patch set 84 02/28/25, 08:48
Reply
I currently run a 34" WQHD Ultra-Widescreen - and the current dashboard is pretty unusable for me. But I also consider my resolution as the minority of users that can be considered an edge case. We are aware that we can make better use of the space, if it´s available. But this will not make it into this patch and probably not v13 as we tried to at least keep some guidelines on how it is currently used. We prepared the structure to be capable of handling the following in the future: Resizing of widgets while respecting the minimum size of a widget, that means that the current settings for widgets will be seen as a minimum config, and we will be able to change dimensions of a widget in the future (stored per viewpoint). We prepared the codebase that we can allow more than the current 4 columns in the future. This will allow better usage of the space, but we feared that it will distort current dashboards and wanted to see how it works out when we implement the resizing. For now, the goal of the dashboard is to be responsive, and it behaves more or less the same as before in terms of scaling of widgets / and viewport resizes except the max width on the container. We will see how this works out and are open to make adjustments when we see how it´s received. With the new base widths for widgets, we at least have something the developer can design their widgets around, and yes, they also need to consider mobile usage. -
Benni Mack commented on patch set 84 CR +1 V +1 02/28/25, 08:54
agreed. let's get this large change in and then do the fine-tuning later. -
Benjamin Kott commented on patch set 84 CR -1 02/28/25, 08:57
on it -
Benjamin Kott uploaded patch set 85
CR +1V +102/28/25, 09:08 -
Benjamin Franzke voted on patch set 85 CR +1 V +1 02/28/25, 09:09
-
core-ci voted on patch set 85 V +1 02/28/25, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74876
-
Benni Mack voted on patch set 85 CR +1 V +1 02/28/25, 09:25
-
Benjamin Kott voted on patch set 85 CR +2 V +2 02/28/25, 09:32
-
Benjamin Kott uploaded patch set 86
CR +1V +102/28/25, 09:39 -
Benjamin Franzke uploaded patch set 87 02/28/25, 09:40
-
Benni Mack voted on patch set 87 CR +1 V +1 02/28/25, 09:43
-
core-ci voted on patch set 87 V +1 02/28/25, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74883
-
Benjamin Kott voted on patch set 87 CR +2 V +2 02/28/25, 09:56
-
Benjamin Kott merged patch set 88 02/28/25, 09:57