84101[TASK] Fix error message for PAGEVIEW template
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1316
-
Lina Wolf uploaded patch set 1 05/01/24, 14:02
-
core-ci voted on patch set 1 V +1 05/01/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57047
-
Nikita Hovratov commented on patch set 1 05/01/24, 17:17
PageViewContentObject.php:115Looks like white-space is missing before "or".PageViewContentObject.php:116Could you change "templateRootPaths" to just "paths" here as drive-by, please? This got changed last-minute in review. -
Lina Wolf uploaded patch set 2
V +105/01/24, 17:32 -
Lina Wolf commented on patch set 2 05/01/24, 17:32
PageViewContentObject.php:115ReplyDonePageViewContentObject.php:115ReplyDonePageViewContentObject.php:116ReplyDone -
core-ci voted on patch set 2 V +1 05/01/24, 17:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57050
-
Nikita Hovratov voted on patch set 2 CR +1 05/01/24, 17:54
-
Nikita Hovratov voted on patch set 2 V +1 05/01/24, 17:56
-
Benjamin Franzke commented on patch set 2 05/02/24, 06:03
PageViewContentObject.php:114Since the implementation above prefers `pages` over `Pages` we should probably list the possible paths in that order as well. -
Lina Wolf commented on patch set 2 05/02/24, 06:06
PageViewContentObject.php:114ReplyAccording to the changelog entry "In order to reduce the burden for integrators, the folder names for "pages", "layouts" and "partials" can start with a lowercase or an uppercase letter." Lowercase was added and ucfirst is used in all the examples in the changelog entry -
Benjamin Franzke uploaded patch set 3
CR +1V +105/03/24, 07:17 -
Benjamin Franzke commented on patch set 3 05/03/24, 07:17
PageViewContentObject.php:114ReplyAcknowledged -
core-ci voted on patch set 3 V +1 05/03/24, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57157
-
Nikita Hovratov voted on patch set 3 CR +1 05/03/24, 07:47
-
Nikita Hovratov voted on patch set 3 CR +2 V +2 05/03/24, 07:56
-
Nikita Hovratov merged patch set 4 05/03/24, 07:56
PageViewContentObject.php:115