84102[TASK] Update rollup to 4.17.2
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 27
- Build/rollup/ckeditor.js+6 −5
- Build/rollup/config.jsnew+13 −0
- Build/rollup/lodash.js+2 −0
- Build/rollup/package.jsonnew+3 −0
- Build/rollup/select-pure.js+2 −0
- Build/Gruntfile.js+1 −1
- Build/package-lock.json+171 −253
- Build/package.json+4 −4
- Build/rollup.config.jsdeleted+0 −13
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap.js+1 −1
- typo3/sysext/dashboard/Resources/Public/JavaScript/Contrib/chartjs.js+3 −3
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-basic-styles.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-block-quote.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-clipboard.js+3 −2
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-code-block.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-editor-classic.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-engine.js+16 −16
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-font.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-heading.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-horizontal-line.js+1 −1
Show 7 more files
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-html-support.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-inspector.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-link.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-show-blocks.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-source-editing.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-theme-lark.js2+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-upload.js+1 −1
Review log 1826
Show 1 earlier messages
-
Andreas Nedbal uploaded patch set 1 05/01/24, 17:40
-
core-ci voted on patch set 1 V -1 05/01/24, 17:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57051
-
Andreas Nedbal uploaded patch set 2
V -105/01/24, 17:59 -
core-ci voted on patch set 2 V +1 05/01/24, 18:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57052
-
Andreas Nedbal updated the commit message in patch set 3
V +105/01/24, 18:08 -
core-ci voted on patch set 3 V +1 05/01/24, 18:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57053
-
Benjamin Franzke uploaded patch set 4
V +105/02/24, 06:27 -
core-ci voted on patch set 4 V +1 05/02/24, 06:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57077
-
Benni Mack voted on patch set 4 CR +1 V +1 05/02/24, 06:34
-
Benjamin Franzke commented on patch set 4 CR -1 05/02/24, 06:41
on it -
Andreas Kienast commented on patch set 4 05/02/24, 06:46
How was this measured? `time ./node_modules/grunt/bin/grunt exec:rollup` is approx. 1 second slower with the patch applied on my machine (Apple M3 Pro, 36 GB RAM). -
Benjamin Franzke uploaded patch set 5
CR +1V +105/02/24, 07:06 -
core-ci voted on patch set 5 V -1 05/02/24, 07:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57078
-
Benjamin Franzke uploaded patch set 6
CR +1V +105/02/24, 07:11 -
Benjamin Franzke commented on patch set 6 V 0 05/02/24, 07:16
Reply
same here, i neither improvement on linux * v2: 18 vs v4: 19 seconds on my workstation. * v2: 58 vs v4: 59 seconds on my laptop. -
core-ci voted on patch set 6 V -1 05/02/24, 07:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57079
-
Benjamin Franzke uploaded patch set 7
CR +1V -105/02/24, 07:20 -
Benjamin Franzke commented on patch set 7 05/02/24, 07:20
Reply
I'll remove this comment from now. -
core-ci voted on patch set 7 V -1 05/02/24, 07:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57080
-
Benjamin Franzke uploaded patch set 8
CR +1V +105/02/24, 07:29 -
Benjamin Franzke commented on patch set 8 V -1 05/02/24, 07:32
ckeditor5-theme-lark.js:1style-inject missing -
core-ci voted on patch set 8 V +1 05/02/24, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57081
-
Benjamin Franzke commented on patch set 8 V +1 05/02/24, 08:28
ckeditor5-theme-lark.js:1Replyactually not missing, but optimized away by rollup, as the stylesheet is empty. -
Andreas Kienast voted on patch set 8 CR +1 V +1 05/02/24, 18:23
-
Benjamin Franzke commented on patch set 8 CR +2 V +2 05/03/24, 06:16
Reply
Done -
Benjamin Franzke merged patch set 9 05/03/24, 06:23