Review main Merged

84104[BUGFIX] Make honeypot fields of EXT:form W3C valid

Georg Ringer CR +2 V +2 Easy +5 −5 updated 08/12/25, 20:21

Commit message

The autocomplete attribute must not be a random string.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Anja Leichsenring +1
    • Josua Vogel +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Josua Vogel +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 2329

Show 34 earlier messages
  1. Georg Ringer uploaded patch set 1 05/02/24, 09:07

  2. Georg Ringer commented on patch set 1 05/02/24, 09:08

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 05/02/24, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57083

  4. Georg Ringer uploaded patch set 2 V -1 05/02/24, 09:36

  1. core-ci voted on patch set 2 V +1 05/02/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57084

  2. Markus Klein voted on patch set 2 CR +1 05/02/24, 20:19

  3. Oliver Klee voted on patch set 2 CR +1 V +1 05/02/24, 22:02

  4. Simon Schaufelberger voted on patch set 2 CR +1 V +1 05/02/24, 22:12

  5. Björn Jacob commented on patch set 2 V -1 05/03/24, 06:14

    There was a reason why we chose a random string in the past. Please check out #89420. Based on this one we should decide what we can do. Nearly 5 years since #89420 was merged. Maybe something has been improved on this side. Please also consider that the whole honeypot implementation is broken, see #93435. That means the honeypot is far from being a useful spam protection.
  6. Volker Kemeter voted on patch set 2 CR +1 05/03/24, 07:07

  7. Georg Ringer commented on patch set 2 05/03/24, 08:26

    Reply

    @bjoern.jacob@tritum.de so how to proceed?
  8. Simon Schaufelberger updated the commit message in patch set 3 CR +1 V +1 05/03/24, 09:50

  9. core-ci voted on patch set 3 V +1 05/03/24, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57169

  10. Benni Mack updated the commit message in patch set 4 V +1 10/18/24, 13:30

  11. core-ci voted on patch set 4 V -1 10/18/24, 20:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67975

  12. Benni Mack rebased onto patch set 5 V -1 10/29/24, 09:43

  13. core-ci voted on patch set 5 V +1 10/29/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68773

  14. Simon Schaufelberger voted on patch set 5 CR +1 10/29/24, 10:49

  15. Oliver Klee wrote 10/29/24, 11:21

    Removed reviewer Oliver Klee.
  16. Oliver Hader commented on patch set 5 CR +1 10/29/24, 18:33

    The goal for that field is actually not to be filled... It feels(!) better with dropping the `autocomplete` attribute - which still is ignored/overruled by browsers. I'm trying to find a way to actually test the "correct" behavior...
  17. Benni Mack wrote 03/28/25, 09:16

    Topic set to form
  18. Benni Mack rebased onto patch set 6 CR +1 V +1 03/28/25, 09:42

  19. core-ci voted on patch set 6 V +1 03/28/25, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76562

  20. Markus Klein voted on patch set 6 CR +1 03/28/25, 15:49

  21. Josua Vogel commented on patch set 6 CR +1 V +1 07/21/25, 14:00

    Worked for me
  22. Anja Leichsenring voted on patch set 6 CR +1 V +1 08/07/25, 19:24

  23. Oliver Hader voted on patch set 6 CR +1 V +1 08/10/25, 10:48

  24. Christian Kuhn voted on patch set 6 CR +2 V +2 08/12/25, 20:15

  25. Christian Kuhn merged patch set 7 08/12/25, 20:21