Review 12.4 Merged

84106[TASK] Add title and aria-label to clear input button

Benjamin Franzke CR +2 V +2 Normal +45 −7 updated 05/02/24, 10:33

Commit message

The clear-input button now has a proper title and additionally an
aria-label to guide visually impaired users.

The button isn't read out by screenreaders when navigating the site
linearly (due to tabindex="-1") but when hold-pressing the button with
the mouse pointer, a screenreader will search for a human readable
label. We therefore add an aria-label attribute. The title attribute is
added for sighted users but will be ignored by screenreaders since it's
value equals the value of the aria-label attribute.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 23

  1. Benjamin Franzke uploaded patch set 1 05/02/24, 10:26

  2. core-ci voted on patch set 1 V +1 05/02/24, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57086

  3. Benjamin Franzke merged patch set 2 05/02/24, 10:33